[GitHub] davisp commented on a change in pull request #1186: [WIP] Clustered purge mixed cluster upgrade

[GitBox <gi...@apache.org>]

davisp commented on a change in pull request #1186: [WIP] Clustered purge mixed cluster upgrade
URL: https://github.com/apache/couchdb/pull/1186#discussion_r171618547
 
 

 ##########
 File path: src/couch/src/couch_bt_engine.erl
 ##########
 @@ -759,6 +777,45 @@ set_default_security_object(Fd, Header, Compression, Options) ->
     end.
 
 
+% This function is to rollback pf clustered purge.
+% It replaces purge_tree_state and upurge_tree_state with
+% with purged_docs disk pointer that stores only the last purge request
+downgrade_purge_info(Fd, Header) ->
+    {db_header, _, UpSeq, _, IdTreeState, SeqTreeState, LocalTreeState, PSeq,
 
 Review comment:
   Can you reformat this so that it's one field per line and includes names for the _ variables that are ignored? I had to refer back and forth to the various header definitions to understand what was being dropped in each of those wild card matches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services