You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by grzegorz-dubicki <gi...@git.apache.org> on 2015/01/25 14:26:27 UTC
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
GitHub user grzegorz-dubicki opened a pull request:
https://github.com/apache/spark/pull/4196
SPARK-5403: Avoid spark-ec2 hanging on "Waiting for (...) 'ssh-ready' state."
See https://issues.apache.org/jira/browse/SPARK-5403
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grzegorz-dubicki/spark SPARK-5403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4196
----
commit a7d863f24be7e22a243c906853aed03d28adef1d
Author: Grzegorz Dubicki <gr...@gmail.com>
Date: 2015-01-20T11:20:19Z
Resolve start command hanging issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by cfeduke <gi...@git.apache.org>.
Github user cfeduke commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71408607
I applied this patch in order to get my Spark cluster on EC2 operational.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71857404
Hey @grzegorz-dubicki, could you edit the title of this PR and [the matching JIRA issue](https://issues.apache.org/jira/browse/SPARK-5403) to something more descriptive? Perhaps something like "Ignore UserKnownHostsFile in SSH calls".
There are several possible causes behind `spark-ec2` hanging on launch, so it would be good to specify what exactly we're fixing here. The PR and JIRA titles become part of the commit history and release notes, respectively.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-73333988
I'm going to merge this into `master` (1.4.0) and `branch-1.3` (1.3.0). I think that this is the right default for most users; if this change causes problems for anyone who depended on the old behavior, we can consider adding a flag for this (or users can just comment out that line themselves, which is a pretty easy workaround).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-72139824
> The one downside is that if we don't add it to the known_hosts file then users will be prompted when they try to say ssh into the master instance.
Yeah, this is pretty much the only risk here. If we take the view that we can _never_ create user-observable performance regressions in maintenance releases, then I think we can only merge this into master and not into the maintenance branches. `spark-ec2` is pretty decoupled from the rest of the Spark release, though, so I don't think it's a big deal to not backport this fix to maintenance branches. I think we're probably safe to merge this into master and mention the change in the 1.3.0 release notes. @pwendell, do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by grzegorz-dubicki <gi...@git.apache.org>.
Github user grzegorz-dubicki commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-72012587
@nchammas done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71554033
I just found another old JIRA asking for the same fix: https://issues.apache.org/jira/browse/SPARK-926. This seems okay to me: we already disable strict host key checking, so I don't think that this change represents a serious security concern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71562690
[Test build #26120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26120/consoleFull) for PR 4196 at commit [`a7d863f`](https://github.com/apache/spark/commit/a7d863f24be7e22a243c906853aed03d28adef1d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-72103634
LGTM.
cc @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-72117689
This sounds reasonable to me. The one downside is that if we don't add it to the `known_hosts` file then users will be prompted when they try to say ssh into the master instance. Its not a big issue though IMHO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71373082
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-72139855
s/performance/behavior
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Ignore UserKnownHostsFile in SSH c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71562702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26120/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71553366
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5403: Avoid spark-ec2 hanging on "Waitin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4196#issuecomment-71553549
[Test build #26120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26120/consoleFull) for PR 4196 at commit [`a7d863f`](https://github.com/apache/spark/commit/a7d863f24be7e22a243c906853aed03d28adef1d).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org