[PR] Miscellaneous cleaning up [jena]

["afs (via GitHub)" <gi...@apache.org>]

afs opened a new pull request, #2369:
URL: https://github.com/apache/jena/pull/2369

   Some clearing up.
   
   The biggest change is to undo the chaining style of the `AWriter` abstraction (a simplifer writer-like interface) and also used in settter for `IndentedWriter`.
   
   The chaining was to allow setters like `setLineNumbers` and output functions `print` to chain:
   
   ```
      AWriter out = IndentedWriter.stdout.clone().setLineNumbers(true);
      out.println("foo").println("bar");
   ```
   
   But this causes a lot of IDE warnings. The result of a chain-able method is `this` but the IDE does not know that fact. 
   It looks to the IDE like a fresh AutoClosable resource and it suggests try-with-resource. Only the outer resource needs that.
   
   Fortunately, this is a primarily internal class, the chaining was added recently at 5.0.0, and chaining has not been retro-applied much in the code base.
   
   ---
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

Re: [PR] Miscellaneous cleaning up [jena]

["afs (via GitHub)" <gi...@apache.org>]

afs merged PR #2369:
URL: https://github.com/apache/jena/pull/2369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org