You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2020/08/04 07:58:00 UTC
[jira] [Comment Edited] (PHOENIX-6010) Create phoenix-thirdparty,
and consume guava through it
[ https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170563#comment-17170563 ]
Istvan Toth edited comment on PHOENIX-6010 at 8/4/20, 7:57 AM:
---------------------------------------------------------------
The above assumes that Omid and Tephra support is intended to be updated in the 4.x branch.
I have noticed the [~anew] has removed Java7 support for Tephra in TEPHRA-304 .
I am not sure if that decision has taken into account the Phoenix 4.x situation, but if it was intentional, and there are no plans to update Tephra (and Omid) in 4.x beyond the current versions (or maybe the plan is to create a 0.15.1 for 4.x specific fixes), then we can bump Omid to Java 8 as well, and scrap the 4.x compatibility aspects of the phoenix-thirdparty refactor, which means that using Guava 29-jre is a no-brainer.
was (Author: stoty):
The above assumes that Omid and Tephra support is intended to be updated in the 4.x branch.
I have noticed the [~anew] has removed Java7 support for Tephra in TEPHRA-301 .
I am not sure if that decision has taken into account the Phoenix 4.x situation, but if it was intentional, and there are no plans to update Tephra (and Omid) in 4.x beyond the current versions (or maybe the plan is to create a 0.15.1 for 4.x specific fixes), then we can bump Omid to Java 8 as well, and scrap the 4.x compatibility aspects of the phoenix-thirdparty refactor, which means that using Guava 29-jre is a no-brainer.
> Create phoenix-thirdparty, and consume guava through it
> -------------------------------------------------------
>
> Key: PHOENIX-6010
> URL: https://issues.apache.org/jira/browse/PHOENIX-6010
> Project: Phoenix
> Issue Type: Improvement
> Components: core, omid, tephra
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> We have long-standing and well-documented problems with Guava, just like the rest of the Hadoop components.
> Adopt the solution used by HBase:
> * create phoenix-thirdparty repo
> * create a pre-shaded phoenix-shaded-guava artifact in it
> * Use the pre-shaded Guava in every phoenix component
> The advantages are well-known, but to name a few:
> * Phoenix will work with Hadoop 3.1.3+
> * One less CVE in our direct dependencies
> * No more conflict with our consumer's Guava versions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)