You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/09/07 16:03:03 UTC
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1652: MINIFICPP-2195 fix flaky MQTT docker tests
martinzink opened a new pull request, #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652#discussion_r1319983450
##########
docker/test/integration/features/steps/steps.py:
##########
Review Comment:
Is the "an MQTT broker is deployed in correspondence with the PublishMQTT" step correct? Should it be removed and the "an MQTT broker is set up in correspondence with the PublishMQTT" step used instead?
##########
docker/test/integration/features/steps/steps.py:
##########
@@ -428,6 +428,7 @@ def step_impl(context):
@given("an MQTT broker is set up in correspondence with the PublishMQTT and ConsumeMQTT")
def step_impl(context):
context.test.acquire_container(context=context, name="mqtt-broker", engine="mqtt-broker")
+ context.test.start('mqtt-broker')
Review Comment:
We already have a "the MQTT broker is started" step for this, which is used in the `Retained message` scenario outline.
It would be better to do this the same way in all scenarios: either add "When/And the MQTT broker is started" to all scenarios and remove the `start` from here, or remove the "the MQTT broker is started" step completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652#discussion_r1321083062
##########
docker/test/integration/features/steps/steps.py:
##########
@@ -428,6 +428,7 @@ def step_impl(context):
@given("an MQTT broker is set up in correspondence with the PublishMQTT and ConsumeMQTT")
def step_impl(context):
context.test.acquire_container(context=context, name="mqtt-broker", engine="mqtt-broker")
+ context.test.start('mqtt-broker')
Review Comment:
I've merged the steps you mentioned in https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b
##########
docker/test/integration/features/steps/steps.py:
##########
Review Comment:
Good idea I've merged the steps you mentioned in https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org