You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/01/17 16:16:04 UTC

[GitHub] brooklyn-server pull request #932: collect supertypes for registered types

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/932#discussion_r162093169
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -1441,15 +1453,23 @@ private String makeAsIndentedObject(String yaml) {
         
         @Override
         public List<? extends CatalogItem<?,?>> addItems(String yaml) {
    -        return addItems(yaml, false);
    +        return addItems(yaml, true, false);
         }
         
    +    /** @deprecated since 1.0.0 use {@link #addItems(String)} or {@link #addItems(String, boolean, boolean)} */
    +    @Deprecated
         @Override
         public List<? extends CatalogItem<?,?>> addItems(String yaml, boolean forceUpdate) {
    +        return addItems(yaml, true, false);
    --- End diff --
    
    Should this not call `addItems(yaml, true, forceUpdate)`?


---