[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1419: NO MERGE, Trying to run Travis

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1419:
URL: https://github.com/apache/qpid-dispatch/pull/1419#discussion_r744823738



##########
File path: src/alloc_pool.c
##########
@@ -511,7 +513,9 @@ void qd_dealloc(qd_alloc_type_desc_t *desc, qd_alloc_pool_t **tpool, char *p)
     sys_mutex_unlock(desc->lock);
 }
 
-
+// use-after-free; no way to check if memory is freed before
+// accessing it from `qd_alloc_deref_safe_ptr`
+ATTRIBUTE_NO_SANITIZE_ADDRESS

Review comment:
       This macro should be also made to work for TSan. TSan does check for some invalid accesses and it barfs on this one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org