You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Jaydeep Vishwakarma <ja...@gmail.com> on 2016/07/21 18:38:45 UTC
Re: Review Request 42563: user retry-policy in workflow action
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42563/#review143120
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestForkedActionStartXCommand.java (line 227)
<https://reviews.apache.org/r/42563/#comment208856>
As name suggest of this Class the test case should not be here. Can you take this and testUserRetry cases and create a seperate class for them. That makes more sense for these test cases?
docs/src/site/twiki/WorkflowFunctionalSpec.twiki (line 2550)
<https://reviews.apache.org/r/42563/#comment208853>
Can you add description of retry-interval unit.
- Jaydeep Vishwakarma
On Feb. 27, 2016, 12:37 a.m., Satish Saley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42563/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:37 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2440
> https://issues.apache.org/jira/browse/OOZIE-2440
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Currently user retry policy is periodic by default. This patch enables user to mention retry-policy in workflow action. Policy can be periodic or exponential.
>
> https://issues.apache.org/jira/browse/OOZIE-2440
>
>
> Diffs
> -----
>
> client/src/main/resources/oozie-workflow-0.3.xsd 30b31be
> client/src/main/resources/oozie-workflow-0.4.5.xsd 32e932e
> client/src/main/resources/oozie-workflow-0.4.xsd 5654a02
> client/src/main/resources/oozie-workflow-0.5.xsd fda49ed
> core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 5827387
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 4006441
> core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java b024bd0
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 99ace13
> core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java d3a2793
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 03c84f1
> core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java a395b77
> core/src/main/resources/oozie-default.xml faf3740
> core/src/test/java/org/apache/oozie/command/wf/TestForkedActionStartXCommand.java e685621
> docs/src/site/twiki/WorkflowFunctionalSpec.twiki f9ddbb5
>
> Diff: https://reviews.apache.org/r/42563/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Patch after implementing the suggested changes
> https://reviews.apache.org/media/uploaded/files/2016/02/27/80d3f514-c915-4d24-9815-ebba15400beb__OOZIE-2440-3.patch
>
>
> Thanks,
>
> Satish Saley
>
>