You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "James Holmes (JIRA)" <ji...@apache.org> on 2007/08/22 21:28:35 UTC
[jira] Created: (WW-2128) Upgrade to OGNL 2.7
Upgrade to OGNL 2.7
-------------------
Key: WW-2128
URL: https://issues.apache.org/struts/browse/WW-2128
Project: Struts 2
Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: James Holmes
Assignee: James Holmes
Fix For: 2.1.0
Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41996 ]
James Holmes commented on WW-2128:
----------------------------------
Unfortunately, this upgrade failed when I attempted it yesterday. I thought it worked at first, but realized later that the Struts 1 plugin failed to compile because of a change to the ognl.PropertyAccessor interface. Previously the ognl.PropertyAccessor interface only had 2 methods that needed to be implemented: getProperty( ) and setProperty( ). In OGNL 2.7, three more methods were added to the interface: getPropertyClass( ), getSourceAccessor( ), and getSourceSetter( ). Unfortunately I don't have enough knowledge at this time of what's necessary to bring the org.apache.struts2.s1.DynaBeanPropertyAccessor class in compliance with the new version of the OGNL PropertyAccessor interface.
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Fix For: 2.1.0
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Carlos Zuniga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44574#action_44574 ]
Carlos Zuniga commented on WW-2128:
-----------------------------------
One of the main advantages of upgrading OGNL is having better support for generics handling. OGNL 2.7 allows the developers to use generic properties in the actions and the type for those properties would be correctly handled.
cheers,
Carlos
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2128) Upgrade to OGNL 2.7
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2128:
--------------------------
Fix Version/s: (was: 2.1.3)
2.2.x
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44203#action_44203 ]
Don Brown commented on WW-2128:
-------------------------------
Hmm...I wonder if we shouldn't push this off as it might raise more problems then it solves. What do you think Rainer?
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.1.3
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Philip Luppens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44788#action_44788 ]
Philip Luppens commented on WW-2128:
------------------------------------
Gunnar, could you check for a moment if the performance problems are caused by the (UI) tags (just one on a page is enough to kill the performance and make the CPU usage go through the roof) ? Or is it even when using property/iterator tags ?
You can keep an eye on WW-2808 with regards to the tag performance.
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Paul Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44986#action_44986 ]
Paul Johnson commented on WW-2128:
----------------------------------
Greetings~
We have been experiencing similar slowdowns. We have been able to implement the file attached to this ticket... but more complicated expression would not run, and it seems like there is a fair amount to get it all working.
Has anyone taken a look at this recently or made any progress on this issue? Feedback greatly appreciated.
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Gunnar Boström (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44786#action_44786 ]
Gunnar Boström commented on WW-2128:
------------------------------------
I agree with Tom, This kills the performance of our web site.
/Gunnar
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Tom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42951#action_42951 ]
Tom commented on WW-2128:
-------------------------
What about the next part (Most important part) using performance enhancements available in OGNL 2.7. ONGL kills processors in 95% and it's critical for large web apilication. It's very expensive to use struts2. After move on strurs2 (only one aplication) we have to bay 2 new processors. Currently "I think" struts2 is technology for small expensive projects -and is not environmentally-friendly = use more energy (it's sad but true) - please if you don't want help developers, help the word (environment) :) - and add performance enhancements available in OGNL 2.7.
Yours truly.
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Fix For: 2.1.3
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2128) Upgrade to OGNL 2.7
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes resolved WW-2128.
------------------------------
Resolution: Fixed
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: James Holmes
> Fix For: 2.1.0
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41998 ]
James Holmes commented on WW-2128:
----------------------------------
As a side note, I can't see where org.apache.struts2.s1.DynaBeanPropertyAccessor is being used other than in a test case. There's not any mention of it in the plugin documentation either. Anyone have any more info on this? Who created the Struts 1 integration plugin?
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Fix For: 2.1.0
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Rainer Hermanns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44204#action_44204 ]
Rainer Hermanns commented on WW-2128:
-------------------------------------
Agreed... we should tackle this issue with the other major refactorings in 2.5.x
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.1.3
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2128) Upgrade to OGNL 2.7
Posted by "Denis Cabasson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47225#action_47225 ]
Denis Cabasson commented on WW-2128:
------------------------------------
Is this ticket still opened? It seems to have been actually applied, as struts 2.1.8.1 is shipping with the new version of ognl (2.7.3).
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.2.x
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2128) Upgrade to OGNL 2.7
Posted by "Rainer Hermanns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rainer Hermanns reassigned WW-2128:
-----------------------------------
Assignee: Rainer Hermanns
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.1.3
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2128) Upgrade to OGNL 2.7
Posted by "Rainer Hermanns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rainer Hermanns updated WW-2128:
--------------------------------
Attachment: ognl27-support.patch
First start of porting the OGNL 2.7 impl from xwork 1.2.x to 2.1.2.
It is not working yet, cause some properties could not be evaluated properly.
The enhancements in expression compilation to not work at all for now and I am waiting for help and/or feedback on this.
You might want to take this as a start wile "hacking" the expression evaluation stuff in xwork :)
cheers,
Rainer
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.1.3
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WW-2128) Upgrade to OGNL 2.7
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes reopened WW-2128:
------------------------------
Assignee: (was: James Holmes)
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Fix For: 2.1.0
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2128) Upgrade to OGNL 2.7
Posted by "Rainer Hermanns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44204#action_44204 ]
rainerh edited comment on WW-2128 at 6/20/08 6:09 AM:
--------------------------------------------------------------
Agreed... we should tackle this issue with the other major refactorings in XW/S2 2.5.x
was (Author: rainerh):
Agreed... we should tackle this issue with the other major refactorings in 2.5.x
> Upgrade to OGNL 2.7
> -------------------
>
> Key: WW-2128
> URL: https://issues.apache.org/struts/browse/WW-2128
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: James Holmes
> Assignee: Rainer Hermanns
> Fix For: 2.1.3
>
> Attachments: ognl27-support.patch
>
>
> Upgrade the Struts 2 dependency on OGNL from 2.6.11 to 2.7.
> Note that this ticket is for a simple JAR upgrade and does not encompass updating any code to take advantage of the performance enhancements available in OGNL 2.7.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.