You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/07/21 02:52:47 UTC
Review Request 36628: Decrease initial application load time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36628/
-----------------------------------------------------------
Review request for Ambari, Oleg Nechiporenko, Srimanth Gunturi, and Yusaku Sako.
Bugs: AMBARI-12463
https://issues.apache.org/jira/browse/AMBARI-12463
Repository: ambari
Description
-------
Initial application load time (or browser refresh) is taking around 12 seconds on 400 node cluster.
As part of this ticket, application load time needs to be brought down to the acceptable limit.
Diffs
-----
ambari-web/app/controllers/global/cluster_controller.js f83d03e
ambari-web/app/controllers/global/update_controller.js f5c5b84
ambari-web/app/controllers/main.js 09ae8df
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 9f310ee
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 0691891
ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 5251b66
ambari-web/app/controllers/main/alert_definitions_controller.js a1222e5
ambari-web/app/controllers/main/host/details.js 527d07e
ambari-web/app/controllers/main/service.js d87c15c
ambari-web/app/controllers/main/service/add_controller.js adf5c37
ambari-web/app/controllers/main/service/info/configs.js f219f04
ambari-web/app/controllers/main/service/item.js 3312457
ambari-web/app/controllers/main/service/reassign/step4_controller.js 4a58804
ambari-web/app/controllers/main/service/reassign_controller.js 1827bf5
ambari-web/app/controllers/wizard/step7_controller.js 6aba895
ambari-web/app/controllers/wizard/step8_controller.js 6a5cc3c
ambari-web/app/mappers/alert_definition_summary_mapper.js 0642ee6
ambari-web/app/mappers/alert_definitions_mapper.js 99cea05
ambari-web/app/mappers/cluster_mapper.js 95b3075
ambari-web/app/mappers/components_state_mapper.js 1359dc3
ambari-web/app/mappers/racks_mapper.js 47abc4d
ambari-web/app/mappers/service_mapper.js 8a47537
ambari-web/app/messages.js 2799156
ambari-web/app/mixins/common/serverValidator.js 40ab94e
ambari-web/app/mixins/wizard/addSecurityConfigs.js 0b4a51e
ambari-web/app/mixins/wizard/wizardProgressPageController.js 22522ef
ambari-web/app/models.js b4a9d24
ambari-web/app/models/cluster.js 9085058
ambari-web/app/models/master_component.js PRE-CREATION
ambari-web/app/models/service.js 08e1662
ambari-web/app/router.js f745b16
ambari-web/app/routes/add_service_routes.js c646002
ambari-web/app/routes/main.js 78d8243
ambari-web/app/templates/application.hbs f767e54
ambari-web/app/templates/main/alerts.hbs 8fa9093
ambari-web/app/templates/main/host/host_alerts.hbs 675f02e
ambari-web/app/templates/main/service/services/hbase.hbs 1ed96dd
ambari-web/app/templates/main/service/services/hdfs.hbs aac2379
ambari-web/app/templates/main/service/services/storm.hbs 0439232
ambari-web/app/templates/main/service/services/yarn.hbs 3413b19
ambari-web/app/utils/ajax/ajax.js dd82b53
ambari-web/app/utils/components.js 6624ced
ambari-web/app/utils/http_client.js ea05d18
ambari-web/app/utils/updater.js 9dbd83f
ambari-web/app/views/main/dashboard/widgets/datanode_live.js 123e653
ambari-web/app/views/main/dashboard/widgets/node_managers_live.js e2ad245
ambari-web/app/views/main/dashboard/widgets/supervisor_live.js 79a0cb0
ambari-web/app/views/main/host/details/host_component_view.js fece46d
ambari-web/app/views/main/host/summary.js 085ec9f
ambari-web/app/views/main/service/info/configs.js f51baa0
ambari-web/app/views/main/service/reassign/step5_view.js b08df7b
ambari-web/test/controllers/global/cluster_controller_test.js f734dff
ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js e52d8a5
ambari-web/test/controllers/main/host/details_test.js 1883c70
ambari-web/test/controllers/main/service/add_controller_test.js 40f437c
ambari-web/test/controllers/main/service/item_test.js b6e969b
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 849af6e
ambari-web/test/controllers/main/service_test.js 7068112
ambari-web/test/controllers/wizard/step8_test.js a869663
ambari-web/test/mixins/wizard/wizardProgressPageController_test.js f0a46cb
ambari-web/test/router_test.js f5c66a3
ambari-web/test/views/main/dashboard/widgets/node_managers_live_test.js 3f7a4ac
ambari-web/test/views/main/host/details/host_component_view_test.js e0dcb40
Diff: https://reviews.apache.org/r/36628/diff/
Testing
-------
tested on a live cluster with applyig the patch installing cluster, adding host, adding service, kerberizing a cluster and then added a service.
verified that all ambari-web unit tests passess
Thanks,
Jaimin Jetly
Re: Review Request 36628: Decrease initial application load time
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36628/#review92342
-----------------------------------------------------------
ambari-web/app/controllers/global/cluster_controller.js (lines 70 - 75)
<https://reviews.apache.org/r/36628/#comment146453>
The loading progress bar shown on initial application load comprises of this dataLoadlist. Success callback of the API calls made in the loading bar sets the attributes to true.
Attempt is to minimize this list as much as possible. may be remove it completely in the future
- Jaimin Jetly
On July 21, 2015, 12:52 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36628/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 12:52 a.m.)
>
>
> Review request for Ambari, Oleg Nechiporenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-12463
> https://issues.apache.org/jira/browse/AMBARI-12463
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Initial application load time (or browser refresh) is taking around 12 seconds on 400 node cluster.
>
> As part of this ticket, application load time needs to be brought down to the acceptable limit.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/cluster_controller.js f83d03e
> ambari-web/app/controllers/global/update_controller.js f5c5b84
> ambari-web/app/controllers/main.js 09ae8df
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 9f310ee
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 0691891
> ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 5251b66
> ambari-web/app/controllers/main/alert_definitions_controller.js a1222e5
> ambari-web/app/controllers/main/host/details.js 527d07e
> ambari-web/app/controllers/main/service.js d87c15c
> ambari-web/app/controllers/main/service/add_controller.js adf5c37
> ambari-web/app/controllers/main/service/info/configs.js f219f04
> ambari-web/app/controllers/main/service/item.js 3312457
> ambari-web/app/controllers/main/service/reassign/step4_controller.js 4a58804
> ambari-web/app/controllers/main/service/reassign_controller.js 1827bf5
> ambari-web/app/controllers/wizard/step7_controller.js 6aba895
> ambari-web/app/controllers/wizard/step8_controller.js 6a5cc3c
> ambari-web/app/mappers/alert_definition_summary_mapper.js 0642ee6
> ambari-web/app/mappers/alert_definitions_mapper.js 99cea05
> ambari-web/app/mappers/cluster_mapper.js 95b3075
> ambari-web/app/mappers/components_state_mapper.js 1359dc3
> ambari-web/app/mappers/racks_mapper.js 47abc4d
> ambari-web/app/mappers/service_mapper.js 8a47537
> ambari-web/app/messages.js 2799156
> ambari-web/app/mixins/common/serverValidator.js 40ab94e
> ambari-web/app/mixins/wizard/addSecurityConfigs.js 0b4a51e
> ambari-web/app/mixins/wizard/wizardProgressPageController.js 22522ef
> ambari-web/app/models.js b4a9d24
> ambari-web/app/models/cluster.js 9085058
> ambari-web/app/models/master_component.js PRE-CREATION
> ambari-web/app/models/service.js 08e1662
> ambari-web/app/router.js f745b16
> ambari-web/app/routes/add_service_routes.js c646002
> ambari-web/app/routes/main.js 78d8243
> ambari-web/app/templates/application.hbs f767e54
> ambari-web/app/templates/main/alerts.hbs 8fa9093
> ambari-web/app/templates/main/host/host_alerts.hbs 675f02e
> ambari-web/app/templates/main/service/services/hbase.hbs 1ed96dd
> ambari-web/app/templates/main/service/services/hdfs.hbs aac2379
> ambari-web/app/templates/main/service/services/storm.hbs 0439232
> ambari-web/app/templates/main/service/services/yarn.hbs 3413b19
> ambari-web/app/utils/ajax/ajax.js dd82b53
> ambari-web/app/utils/components.js 6624ced
> ambari-web/app/utils/http_client.js ea05d18
> ambari-web/app/utils/updater.js 9dbd83f
> ambari-web/app/views/main/dashboard/widgets/datanode_live.js 123e653
> ambari-web/app/views/main/dashboard/widgets/node_managers_live.js e2ad245
> ambari-web/app/views/main/dashboard/widgets/supervisor_live.js 79a0cb0
> ambari-web/app/views/main/host/details/host_component_view.js fece46d
> ambari-web/app/views/main/host/summary.js 085ec9f
> ambari-web/app/views/main/service/info/configs.js f51baa0
> ambari-web/app/views/main/service/reassign/step5_view.js b08df7b
> ambari-web/test/controllers/global/cluster_controller_test.js f734dff
> ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js e52d8a5
> ambari-web/test/controllers/main/host/details_test.js 1883c70
> ambari-web/test/controllers/main/service/add_controller_test.js 40f437c
> ambari-web/test/controllers/main/service/item_test.js b6e969b
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 849af6e
> ambari-web/test/controllers/main/service_test.js 7068112
> ambari-web/test/controllers/wizard/step8_test.js a869663
> ambari-web/test/mixins/wizard/wizardProgressPageController_test.js f0a46cb
> ambari-web/test/router_test.js f5c66a3
> ambari-web/test/views/main/dashboard/widgets/node_managers_live_test.js 3f7a4ac
> ambari-web/test/views/main/host/details/host_component_view_test.js e0dcb40
>
> Diff: https://reviews.apache.org/r/36628/diff/
>
>
> Testing
> -------
>
> tested on a live cluster with applyig the patch installing cluster, adding host, adding service, kerberizing a cluster and then added a service.
>
> verified that all ambari-web unit tests passess
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 36628: Decrease initial application load time
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36628/#review92450
-----------------------------------------------------------
Ship it!
Was able to use latest code and load UI in ~6s for 800 node cluster.
- Srimanth Gunturi
On July 21, 2015, 6:29 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36628/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 6:29 p.m.)
>
>
> Review request for Ambari, Oleg Nechiporenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-12463
> https://issues.apache.org/jira/browse/AMBARI-12463
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Initial application load time (or browser refresh) is taking around 12 seconds on 400 node cluster.
>
> As part of this ticket, application load time needs to be brought down to the acceptable limit.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/cluster_controller.js f83d03e
> ambari-web/app/controllers/global/update_controller.js 9a1d53a
> ambari-web/app/controllers/main.js 09ae8df
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 9f310ee
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 0691891
> ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 5251b66
> ambari-web/app/controllers/main/alert_definitions_controller.js a1222e5
> ambari-web/app/controllers/main/host/details.js 87da8c2
> ambari-web/app/controllers/main/service.js d87c15c
> ambari-web/app/controllers/main/service/add_controller.js adf5c37
> ambari-web/app/controllers/main/service/info/configs.js f219f04
> ambari-web/app/controllers/main/service/item.js 3312457
> ambari-web/app/controllers/main/service/reassign/step4_controller.js 4a58804
> ambari-web/app/controllers/main/service/reassign_controller.js 1827bf5
> ambari-web/app/controllers/wizard/step7_controller.js 6aba895
> ambari-web/app/controllers/wizard/step8_controller.js 6a5cc3c
> ambari-web/app/mappers/alert_definition_summary_mapper.js 0642ee6
> ambari-web/app/mappers/alert_definitions_mapper.js 99cea05
> ambari-web/app/mappers/cluster_mapper.js 95b3075
> ambari-web/app/mappers/components_state_mapper.js 1359dc3
> ambari-web/app/mappers/racks_mapper.js 47abc4d
> ambari-web/app/mappers/service_mapper.js 8a47537
> ambari-web/app/messages.js 2799156
> ambari-web/app/mixins/common/serverValidator.js 40ab94e
> ambari-web/app/mixins/wizard/addSecurityConfigs.js 0b4a51e
> ambari-web/app/mixins/wizard/wizardProgressPageController.js 22522ef
> ambari-web/app/models.js b4a9d24
> ambari-web/app/models/cluster.js 9085058
> ambari-web/app/models/master_component.js PRE-CREATION
> ambari-web/app/models/service.js a255157
> ambari-web/app/router.js f745b16
> ambari-web/app/routes/add_service_routes.js c646002
> ambari-web/app/routes/main.js 2023ef4
> ambari-web/app/templates/application.hbs f767e54
> ambari-web/app/templates/main/alerts.hbs 8fa9093
> ambari-web/app/templates/main/host/host_alerts.hbs 675f02e
> ambari-web/app/templates/main/service/services/hbase.hbs 1ed96dd
> ambari-web/app/templates/main/service/services/hdfs.hbs aac2379
> ambari-web/app/templates/main/service/services/storm.hbs 0439232
> ambari-web/app/templates/main/service/services/yarn.hbs 3413b19
> ambari-web/app/utils/ajax/ajax.js dd82b53
> ambari-web/app/utils/components.js 6624ced
> ambari-web/app/utils/http_client.js ea05d18
> ambari-web/app/utils/updater.js 9dbd83f
> ambari-web/app/views/main/dashboard/widgets/datanode_live.js 123e653
> ambari-web/app/views/main/dashboard/widgets/node_managers_live.js e2ad245
> ambari-web/app/views/main/dashboard/widgets/supervisor_live.js 79a0cb0
> ambari-web/app/views/main/host/details/host_component_view.js fece46d
> ambari-web/app/views/main/host/summary.js 085ec9f
> ambari-web/app/views/main/service/info/configs.js f51baa0
> ambari-web/app/views/main/service/reassign/step5_view.js b08df7b
> ambari-web/test/controllers/global/cluster_controller_test.js f734dff
> ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js e52d8a5
> ambari-web/test/controllers/main/host/details_test.js cd35981
> ambari-web/test/controllers/main/service/add_controller_test.js 40f437c
> ambari-web/test/controllers/main/service/item_test.js b6e969b
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 849af6e
> ambari-web/test/controllers/main/service_test.js 7068112
> ambari-web/test/controllers/wizard/step8_test.js a869663
> ambari-web/test/mixins/wizard/wizardProgressPageController_test.js f0a46cb
> ambari-web/test/router_test.js f5c66a3
> ambari-web/test/views/main/dashboard/widgets/node_managers_live_test.js 3f7a4ac
> ambari-web/test/views/main/host/details/host_component_view_test.js e0dcb40
>
> Diff: https://reviews.apache.org/r/36628/diff/
>
>
> Testing
> -------
>
> tested on a live cluster with applyig the patch installing cluster, adding host, adding service, kerberizing a cluster and then added a service.
>
> verified that all ambari-web unit tests passess
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 36628: Decrease initial application load time
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36628/
-----------------------------------------------------------
(Updated July 21, 2015, 6:29 p.m.)
Review request for Ambari, Oleg Nechiporenko, Srimanth Gunturi, and Yusaku Sako.
Changes
-------
2nd patch primarily removes host API request as part of the progress bar.
Bugs: AMBARI-12463
https://issues.apache.org/jira/browse/AMBARI-12463
Repository: ambari
Description
-------
Initial application load time (or browser refresh) is taking around 12 seconds on 400 node cluster.
As part of this ticket, application load time needs to be brought down to the acceptable limit.
Diffs (updated)
-----
ambari-web/app/controllers/global/cluster_controller.js f83d03e
ambari-web/app/controllers/global/update_controller.js 9a1d53a
ambari-web/app/controllers/main.js 09ae8df
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 9f310ee
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 0691891
ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 5251b66
ambari-web/app/controllers/main/alert_definitions_controller.js a1222e5
ambari-web/app/controllers/main/host/details.js 87da8c2
ambari-web/app/controllers/main/service.js d87c15c
ambari-web/app/controllers/main/service/add_controller.js adf5c37
ambari-web/app/controllers/main/service/info/configs.js f219f04
ambari-web/app/controllers/main/service/item.js 3312457
ambari-web/app/controllers/main/service/reassign/step4_controller.js 4a58804
ambari-web/app/controllers/main/service/reassign_controller.js 1827bf5
ambari-web/app/controllers/wizard/step7_controller.js 6aba895
ambari-web/app/controllers/wizard/step8_controller.js 6a5cc3c
ambari-web/app/mappers/alert_definition_summary_mapper.js 0642ee6
ambari-web/app/mappers/alert_definitions_mapper.js 99cea05
ambari-web/app/mappers/cluster_mapper.js 95b3075
ambari-web/app/mappers/components_state_mapper.js 1359dc3
ambari-web/app/mappers/racks_mapper.js 47abc4d
ambari-web/app/mappers/service_mapper.js 8a47537
ambari-web/app/messages.js 2799156
ambari-web/app/mixins/common/serverValidator.js 40ab94e
ambari-web/app/mixins/wizard/addSecurityConfigs.js 0b4a51e
ambari-web/app/mixins/wizard/wizardProgressPageController.js 22522ef
ambari-web/app/models.js b4a9d24
ambari-web/app/models/cluster.js 9085058
ambari-web/app/models/master_component.js PRE-CREATION
ambari-web/app/models/service.js a255157
ambari-web/app/router.js f745b16
ambari-web/app/routes/add_service_routes.js c646002
ambari-web/app/routes/main.js 2023ef4
ambari-web/app/templates/application.hbs f767e54
ambari-web/app/templates/main/alerts.hbs 8fa9093
ambari-web/app/templates/main/host/host_alerts.hbs 675f02e
ambari-web/app/templates/main/service/services/hbase.hbs 1ed96dd
ambari-web/app/templates/main/service/services/hdfs.hbs aac2379
ambari-web/app/templates/main/service/services/storm.hbs 0439232
ambari-web/app/templates/main/service/services/yarn.hbs 3413b19
ambari-web/app/utils/ajax/ajax.js dd82b53
ambari-web/app/utils/components.js 6624ced
ambari-web/app/utils/http_client.js ea05d18
ambari-web/app/utils/updater.js 9dbd83f
ambari-web/app/views/main/dashboard/widgets/datanode_live.js 123e653
ambari-web/app/views/main/dashboard/widgets/node_managers_live.js e2ad245
ambari-web/app/views/main/dashboard/widgets/supervisor_live.js 79a0cb0
ambari-web/app/views/main/host/details/host_component_view.js fece46d
ambari-web/app/views/main/host/summary.js 085ec9f
ambari-web/app/views/main/service/info/configs.js f51baa0
ambari-web/app/views/main/service/reassign/step5_view.js b08df7b
ambari-web/test/controllers/global/cluster_controller_test.js f734dff
ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js e52d8a5
ambari-web/test/controllers/main/host/details_test.js cd35981
ambari-web/test/controllers/main/service/add_controller_test.js 40f437c
ambari-web/test/controllers/main/service/item_test.js b6e969b
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 849af6e
ambari-web/test/controllers/main/service_test.js 7068112
ambari-web/test/controllers/wizard/step8_test.js a869663
ambari-web/test/mixins/wizard/wizardProgressPageController_test.js f0a46cb
ambari-web/test/router_test.js f5c66a3
ambari-web/test/views/main/dashboard/widgets/node_managers_live_test.js 3f7a4ac
ambari-web/test/views/main/host/details/host_component_view_test.js e0dcb40
Diff: https://reviews.apache.org/r/36628/diff/
Testing
-------
tested on a live cluster with applyig the patch installing cluster, adding host, adding service, kerberizing a cluster and then added a service.
verified that all ambari-web unit tests passess
Thanks,
Jaimin Jetly
Re: Review Request 36628: Decrease initial application load time
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36628/#review92439
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On July 21, 2015, 12:52 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36628/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 12:52 a.m.)
>
>
> Review request for Ambari, Oleg Nechiporenko, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-12463
> https://issues.apache.org/jira/browse/AMBARI-12463
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Initial application load time (or browser refresh) is taking around 12 seconds on 400 node cluster.
>
> As part of this ticket, application load time needs to be brought down to the acceptable limit.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/global/cluster_controller.js f83d03e
> ambari-web/app/controllers/global/update_controller.js f5c5b84
> ambari-web/app/controllers/main.js 09ae8df
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js 9f310ee
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 0691891
> ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 5251b66
> ambari-web/app/controllers/main/alert_definitions_controller.js a1222e5
> ambari-web/app/controllers/main/host/details.js 527d07e
> ambari-web/app/controllers/main/service.js d87c15c
> ambari-web/app/controllers/main/service/add_controller.js adf5c37
> ambari-web/app/controllers/main/service/info/configs.js f219f04
> ambari-web/app/controllers/main/service/item.js 3312457
> ambari-web/app/controllers/main/service/reassign/step4_controller.js 4a58804
> ambari-web/app/controllers/main/service/reassign_controller.js 1827bf5
> ambari-web/app/controllers/wizard/step7_controller.js 6aba895
> ambari-web/app/controllers/wizard/step8_controller.js 6a5cc3c
> ambari-web/app/mappers/alert_definition_summary_mapper.js 0642ee6
> ambari-web/app/mappers/alert_definitions_mapper.js 99cea05
> ambari-web/app/mappers/cluster_mapper.js 95b3075
> ambari-web/app/mappers/components_state_mapper.js 1359dc3
> ambari-web/app/mappers/racks_mapper.js 47abc4d
> ambari-web/app/mappers/service_mapper.js 8a47537
> ambari-web/app/messages.js 2799156
> ambari-web/app/mixins/common/serverValidator.js 40ab94e
> ambari-web/app/mixins/wizard/addSecurityConfigs.js 0b4a51e
> ambari-web/app/mixins/wizard/wizardProgressPageController.js 22522ef
> ambari-web/app/models.js b4a9d24
> ambari-web/app/models/cluster.js 9085058
> ambari-web/app/models/master_component.js PRE-CREATION
> ambari-web/app/models/service.js 08e1662
> ambari-web/app/router.js f745b16
> ambari-web/app/routes/add_service_routes.js c646002
> ambari-web/app/routes/main.js 78d8243
> ambari-web/app/templates/application.hbs f767e54
> ambari-web/app/templates/main/alerts.hbs 8fa9093
> ambari-web/app/templates/main/host/host_alerts.hbs 675f02e
> ambari-web/app/templates/main/service/services/hbase.hbs 1ed96dd
> ambari-web/app/templates/main/service/services/hdfs.hbs aac2379
> ambari-web/app/templates/main/service/services/storm.hbs 0439232
> ambari-web/app/templates/main/service/services/yarn.hbs 3413b19
> ambari-web/app/utils/ajax/ajax.js dd82b53
> ambari-web/app/utils/components.js 6624ced
> ambari-web/app/utils/http_client.js ea05d18
> ambari-web/app/utils/updater.js 9dbd83f
> ambari-web/app/views/main/dashboard/widgets/datanode_live.js 123e653
> ambari-web/app/views/main/dashboard/widgets/node_managers_live.js e2ad245
> ambari-web/app/views/main/dashboard/widgets/supervisor_live.js 79a0cb0
> ambari-web/app/views/main/host/details/host_component_view.js fece46d
> ambari-web/app/views/main/host/summary.js 085ec9f
> ambari-web/app/views/main/service/info/configs.js f51baa0
> ambari-web/app/views/main/service/reassign/step5_view.js b08df7b
> ambari-web/test/controllers/global/cluster_controller_test.js f734dff
> ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js e52d8a5
> ambari-web/test/controllers/main/host/details_test.js 1883c70
> ambari-web/test/controllers/main/service/add_controller_test.js 40f437c
> ambari-web/test/controllers/main/service/item_test.js b6e969b
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 849af6e
> ambari-web/test/controllers/main/service_test.js 7068112
> ambari-web/test/controllers/wizard/step8_test.js a869663
> ambari-web/test/mixins/wizard/wizardProgressPageController_test.js f0a46cb
> ambari-web/test/router_test.js f5c66a3
> ambari-web/test/views/main/dashboard/widgets/node_managers_live_test.js 3f7a4ac
> ambari-web/test/views/main/host/details/host_component_view_test.js e0dcb40
>
> Diff: https://reviews.apache.org/r/36628/diff/
>
>
> Testing
> -------
>
> tested on a live cluster with applyig the patch installing cluster, adding host, adding service, kerberizing a cluster and then added a service.
>
> verified that all ambari-web unit tests passess
>
>
> Thanks,
>
> Jaimin Jetly
>
>