You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zhu Zhu (Jira)" <ji...@apache.org> on 2020/10/19 08:00:29 UTC

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

    [ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216516#comment-17216516 ] 

Zhu Zhu commented on FLINK-19671:
---------------------------------

Hi [~aljoscha], I found the continuation indentation is set to 8, which will result in 2 extra tabs in new line when breaking long lines. This breaks the rule:

{code:java}
Each new line should have one extra indentation (or two for a function declaration) relative to the line of the parent function name or the called entity
{code}



> Update EditorConfig file to be useful
> -------------------------------------
>
>                 Key: FLINK-19671
>                 URL: https://issues.apache.org/jira/browse/FLINK-19671
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>              Labels: pull-request-available
>
> We should update our {{.editorconfig}} file to format Java code according to a style that passes our checkstyle rules and also applies our import ordering. This will greatly simplify development because developers can just "re-format code" in IntelliJ and be done with it.
> See the ML discussion for more background: https://lists.apache.org/thread.html/r481bb622410718cd454d251b194c7c1ad358e5d861fdacc9a4be3b5b%40%3Cdev.flink.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)