You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2006/04/21 23:16:05 UTC
[jira] Created: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Changing pooling parameters for connector does not persist to config.xml
------------------------------------------------------------------------
Key: GERONIMO-1889
URL: http://issues.apache.org/jira/browse/GERONIMO-1889
Project: Geronimo
Type: Bug
Security: public (Regular issues)
Components: connector, kernel, console
Versions: 1.1
Reporter: Aaron Mulder
Priority: Blocker
Fix For: 1.1
To replicate:
Open the console
Select Database Pools
Click the "edit" link to the right of "System Datasource"
Change pool max size to 119
Click Save
Click the "edit" link to the right of "System Datasource"
Confirm that it shows a pool max size of 119
Shut down the server
Grep config.xml for 119, it does not appear
Start the server
Edit the System Datasource again, confirm that the pool max size is NOT 119
Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan updated GERONIMO-1889:
-----------------------------------
Attachment: ACTIVEMQ-gbean.patch
Sent a patch to activemq to address the problem with changes to activemq connectors' host and port attributes not being persisted in config.xml. Attaching the activemq patch to this JIRA as well just for reference.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
> Attachments: ACTIVEMQ-gbean.patch, GERONIMO-1889.patch, GERONIMO-1889.patch.2
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=comments#action_12383358 ]
Aaron Mulder commented on GERONIMO-1889:
----------------------------------------
I checked and the ActiveMQ patch has been applied already.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
> Attachments: ACTIVEMQ-gbean.patch, GERONIMO-1889.patch, GERONIMO-1889.patch.2
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Aaron Mulder resolved GERONIMO-1889:
------------------------------------
Resolution: Fixed
This patch is definitely progress. However, I don't like the console part of the patch. For one thing, I don't like the client being in a position of needing to manually create a proxy because the underlying service didn't do it and should have. On top of that, the security reproxying doesn't appear to be necessary (only for connectors).
Applied the non-console parts of the patch and updated the connector code to return a proxy for the ConnectionManager if it's not already (which, currently, it's not). That should do it.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
> Attachments: ACTIVEMQ-gbean.patch, GERONIMO-1889.patch, GERONIMO-1889.patch.2
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=comments#action_12377940 ]
Aaron Mulder commented on GERONIMO-1889:
----------------------------------------
I think proxies are definitely the short-term plan.
Longer term, we should think about whether the manageable attribute store is the right solution if we're going to try to run without proxies, but I think that's a larger/separate issue.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan updated GERONIMO-1889:
-----------------------------------
Attachment: GERONIMO-1889.patch.2
Thanks to Aaron for the helpful suggestion on a better way to persist attributes. I was thrown off when working on the previous patch by the fact that using a proxy didn't help persist certain attributes. Turns out those attributes were not specified as manageable by their corresponding gbeans. Adding them to the gbean's manageable interfaces and then updating them from the console via a proxy fixed the problem.
One problem remains, though, which is that the host and port attributes for activemq connectors don't persist correctly when changed from the console. I assume its because they are not specified as manageable in the activemq gbean. I will investigate further and open an activemq jira if necessary to get that fixed.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch, GERONIMO-1889.patch.2
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Matt Hogstrom reassigned GERONIMO-1889:
---------------------------------------
Assign To: Paul McMahan
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan updated GERONIMO-1889:
-----------------------------------
Attachment: GERONIMO-1889.patch
In addition to the dbpools there are three other types of changes in the console that are not persisted across server restart:
changes to the JMS connectors
changes to the security realms
changes to the web connectors
The problem is that gbeans that don't already have a corresponding entry in the config.xml are not getting persisted The attached patch forces the LocalAttributeManager to write the config changes for those objects out to config.xml when they are changed. If there's a more generic approach that's cleaner then let me know and I'll rework the patch.
NOTE:
I updated GBeanOverride to check the overridden attributes for null before calling .value() on them. If the attribute is null then I skip it (the attribute is not written to config.xml). Without this change I was getting a NPE when trying to do things like update the attributes of an HTTPS connector since some of its attributes are null. I seem to recall a change going into 1.2 to handle null attributes in a special way but I didn't want to introduce that type of change at this point in 1.1 without further guidance.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=comments#action_12375637 ]
Aaron Mulder commented on GERONIMO-1889:
----------------------------------------
David J says it may be possible to support saving these properties to config.xml via a PropertyEditor and/or something like EnvironmentBuilder
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=comments#action_12377924 ]
Dain Sundstrom commented on GERONIMO-1889:
------------------------------------------
Aaron, that means we must always use proxies for every object in the console, so the setters can be redirected through the GBean system and persist the values. Is that the long term plan?
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan updated GERONIMO-1889:
-----------------------------------
Patch Info: [Patch Available]
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan reassigned GERONIMO-1889:
--------------------------------------
Assign To: Aaron Mulder (was: Paul McMahan)
attached a new patch that implements your suggestion
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch, GERONIMO-1889.patch.2
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Aaron Mulder reassigned GERONIMO-1889:
--------------------------------------
Assign To: Paul McMahan (was: Aaron Mulder)
It should never be necessary for a caller to manually set things on the attribute store like this patch does.
The logic should be, any time the kernel/gbean infrastructure detects a setter call, it notifies the attribute store (that should be in place). When the attribute store gets such a notification, it should locate the configuration and gbean entries in the file. The configuration must be there. If there is no matching gbean entry in that configuration, one should be created. Finally, the new value should be written for the attribute for the gbean, and the method called that causes the file write to be queued.
It looks like this logic is in place in LocalAttributeManager.setValue. We need to find out what's wrong and correct it either there or in the immediate caller, not add manual calls to the attribute store.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Paul McMahan
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1889) Changing pooling parameters for
connector does not persist to config.xml
Posted by "Paul McMahan (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]
Paul McMahan reassigned GERONIMO-1889:
--------------------------------------
Assign To: Aaron Mulder (was: Paul McMahan)
Can you please take a look at the attached patch? Thanks.
> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
> Key: GERONIMO-1889
> URL: http://issues.apache.org/jira/browse/GERONIMO-1889
> Project: Geronimo
> Type: Bug
> Security: public(Regular issues)
> Components: connector, kernel, console
> Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Priority: Blocker
> Fix For: 1.1
> Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira