You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/09/21 19:58:28 UTC
[GitHub] [arrow] sgilmore10 opened a new pull request, #37826: GH-37825: [MATLAB]
sgilmore10 opened a new pull request, #37826:
URL: https://github.com/apache/arrow/pull/37826
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
We should improve the display of `arrow.type.Field`, which currently looks like this:
```matlab
>> arrow.field("A", arrow.int32())
ans =
A: int32
```
This display isn't very "MATLAB-like". For instance, it doesn't display the object's class type. This display would be better:
```matlab
>> arrow.field("A", arrow.int32())
ans =
Field with properties:
Name: "A"
Type: [1x1 arrow.type.Int32Type]
```
### What changes are included in this PR?
1. Added `getPropertyGroups` method to `Field`. This method is inherited from the superclass `matlab.mixin.CustomDisplay`.
2. Removed `displayScalarObject` method from `Field`. This method is also inherited from `matlab.mixin.CustomDisplay`. By implementing `getPropertyGroups`, we no longer need to override `displayScalarObject`.
3. Removed `toString()` method from `Field`. This method was private, and only used by `displayScalarObject`. Now that `displayScalarObject` has been removed, `toString()` can be deleted too.
4. Converted the helper test methods (`makeLinkString`, `makeDimensionString`, `verifyDisplay`) in `tTypeDisplay` into standalone functions. Doing so lets other test classes, such as `tField`, use them.
### Are these changes tested?
Yes. Added a `TestDisplay` unit test to `tField.m`.
### Are there any user-facing changes?
Yes. `arrow.type.Field` objects are now displayed differently in the Command Window.
### Future Directions
1. Update the display of `arrow.tabular.Schema`.
2. Update the display of `arrow.array.Array`.
3. Update the display of `arrow.tabular.Table`.
4. Update the display of `arrow.tabular.RecordBatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37826: GH-37825: [MATLAB] Improve `arrow.type.Field` display
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37826:
URL: https://github.com/apache/arrow/pull/37826#issuecomment-1737570838
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1ae243628611a43812747f3bc1505072a139b1c8.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `ec2-m5-4xlarge-us-east-2` at [2023-09-25 19:11:51Z](https://conbench.ursa.dev/compare/runs/a69d843f61c041058a4cb5155b66b448...1f08fb5c1dfe4333895e9f42def57852/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-15, scale_factor=10](https://conbench.ursa.dev/compare/benchmarks/06511cc82d757d868000ce4783696dc4...06511ed95f977e968000accebf5ff277)
The [full Conbench report](https://github.com/apache/arrow/runs/17184242598) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #37826: GH-37825: [MATLAB] Improve `arrow.type.Field` display
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #37826:
URL: https://github.com/apache/arrow/pull/37826#issuecomment-1734030949
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney merged pull request #37826: GH-37825: [MATLAB] Improve `arrow.type.Field` display
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #37826:
URL: https://github.com/apache/arrow/pull/37826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jgehrcke commented on pull request #37826: GH-37825: [MATLAB] Improve `arrow.type.Field` display
Posted by "jgehrcke (via GitHub)" <gi...@apache.org>.
jgehrcke commented on PR #37826:
URL: https://github.com/apache/arrow/pull/37826#issuecomment-1737597761
> indicating a performance regression:
I looked into this. Does not seem to be an actual regression; also see https://github.com/conbench/conbench/issues/594#issuecomment-1737596499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org