[GitHub] [shardingsphere] sandynz commented on a diff in pull request #27435: Refactor InventoryRecordsCountCalculator.getTableRecordsCount

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #27435:
URL: https://github.com/apache/shardingsphere/pull/27435#discussion_r1272913981


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/preparer/InventoryTaskSplitter.java:
##########
@@ -73,6 +77,15 @@ public final class InventoryTaskSplitter {
     
     private final ImporterConfiguration importerConfig;
     
+    private final Map<String, PipelineDataSourceWrapper> actualDataSourceMap;

Review Comment:
   1, `actualDataSourceMap` is similar as `sourceDataSource`, could we combine them?
   
   2, Could we just use one `sourceDataSource`? Even it's ShardingSphereDataSource.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org