You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/03/14 17:13:31 UTC
Review Request 44792: AMS fails to start with TTL for column family 0
must be positive after upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan and Sid Wagle.
Bugs: AMBARI-15402
https://issues.apache.org/jira/browse/AMBARI-15402
Repository: ambari
Description
-------
TTL should be set in seconds for all the tables and be greater than 0.
timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
Diff: https://reviews.apache.org/r/44792/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/#review123458
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java (line 90)
<https://reviews.apache.org/r/44792/#comment185708>
Minor. Most of these variables will not be required after this change.
- Aravindan Vijayan
On March 14, 2016, 5:25 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44792/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:25 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-15402
> https://issues.apache.org/jira/browse/AMBARI-15402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TTL should be set in seconds for all the tables and be greater than 0.
> timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
>
> Diff: https://reviews.apache.org/r/44792/diff/
>
>
> Testing
> -------
>
> Unit tests passed
> Tested end-to-end
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/#review123463
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On March 14, 2016, 5:25 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44792/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:25 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-15402
> https://issues.apache.org/jira/browse/AMBARI-15402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TTL should be set in seconds for all the tables and be greater than 0.
> timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
>
> Diff: https://reviews.apache.org/r/44792/diff/
>
>
> Testing
> -------
>
> Unit tests passed
> Tested end-to-end
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
> On March 14, 2016, 6:34 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, line 286
> > <https://reviews.apache.org/r/44792/diff/2/?file=1297432#file1297432line286>
> >
> > Is it possible to leave it as it is and conert it to seconds in code?
>
> Dmytro Sen wrote:
> There is no need for 2 extra convertion from sec to days and days to seconds. Seconds is a native time unit used by HBase for TTL as well as for Phoenix DDL queries syntax.
> Numbers of ambari clusters are already installed and use seconds, that's not only possible bug caused by unnessessary values convertion.
DS is right. Ajit, there was a recent patch which converted TTL values from seconds to days for readability purposes - https://reviews.apache.org/r/43385/. This patch essentially reverts that.
- Aravindan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/#review123474
-----------------------------------------------------------
On March 14, 2016, 5:25 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44792/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:25 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-15402
> https://issues.apache.org/jira/browse/AMBARI-15402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TTL should be set in seconds for all the tables and be greater than 0.
> timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
>
> Diff: https://reviews.apache.org/r/44792/diff/
>
>
> Testing
> -------
>
> Unit tests passed
> Tested end-to-end
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Март 14, 2016, 6:34 п.п., Ajit Kumar wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml, line 286
> > <https://reviews.apache.org/r/44792/diff/2/?file=1297432#file1297432line286>
> >
> > Is it possible to leave it as it is and conert it to seconds in code?
There is no need for 2 extra convertion from sec to days and days to seconds. Seconds is a native time unit used by HBase for TTL as well as for Phoenix DDL queries syntax.
Numbers of ambari clusters are already installed and use seconds, that's not only possible bug caused by unnessessary values convertion.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/#review123474
-----------------------------------------------------------
On Март 14, 2016, 5:25 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44792/
> -----------------------------------------------------------
>
> (Updated Март 14, 2016, 5:25 п.п.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-15402
> https://issues.apache.org/jira/browse/AMBARI-15402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TTL should be set in seconds for all the tables and be greater than 0.
> timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
>
> Diff: https://reviews.apache.org/r/44792/diff/
>
>
> Testing
> -------
>
> Unit tests passed
> Tested end-to-end
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Ajit Kumar <aj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/#review123474
-----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 176)
<https://reviews.apache.org/r/44792/#comment185713>
move 86400 to a constant.
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml (line 286)
<https://reviews.apache.org/r/44792/#comment185714>
Is it possible to leave it as it is and conert it to seconds in code?
- Ajit Kumar
On March 14, 2016, 5:25 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44792/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 5:25 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-15402
> https://issues.apache.org/jira/browse/AMBARI-15402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TTL should be set in seconds for all the tables and be greater than 0.
> timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
>
> Diff: https://reviews.apache.org/r/44792/diff/
>
>
> Testing
> -------
>
> Unit tests passed
> Tested end-to-end
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 44792: AMS fails to start with TTL for column
family 0 must be positive after upgrade
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44792/
-----------------------------------------------------------
(Updated Март 14, 2016, 5:25 п.п.)
Review request for Ambari, Aravindan Vijayan and Sid Wagle.
Bugs: AMBARI-15402
https://issues.apache.org/jira/browse/AMBARI-15402
Repository: ambari
Description
-------
TTL should be set in seconds for all the tables and be greater than 0.
timeline.metrics.host.aggregator.daily.ttl was = 0.0 after upgrade.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 611cb92
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 93ba770
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java b3ae237
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml fd1c2ac
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6c62f0f
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 3712994
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 8d8938f
Diff: https://reviews.apache.org/r/44792/diff/
Testing (updated)
-------
Unit tests passed
Tested end-to-end
Thanks,
Dmytro Sen