You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/05/14 23:54:36 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #779: PHOENIX-5896: Implement incremental rebuild along the failed regions …

swaroopak commented on a change in pull request #779:
URL: https://github.com/apache/phoenix/pull/779#discussion_r425492111



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -1191,6 +1203,9 @@ public boolean next(List<Cell> results) throws IOException {
         }
         Cell lastCell = null;
         int rowCount = 0;
+        if(!shouldRebuildOrVerify()) {

Review comment:
       This was one way without taking any additional parameters. I think the read repair won't be impacted as it would have different ts than the key of PIT result and this `if` will not get executed. We can wrap this under a parameter if you think that's the right thing to do.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org