You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2024/07/12 05:18:19 UTC
[PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
stoty opened a new pull request, #6075:
URL: https://github.com/apache/hbase/pull/6075
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291034281
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 1s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 19s | | branch-2 passed |
| +1 :green_heart: | compile | 5m 55s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 15s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 9m 50s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 10s | | the patch passed |
| +1 :green_heart: | compile | 5m 58s | | the patch passed |
| +1 :green_heart: | javac | 5m 58s | | root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 9s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 10m 18s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 6s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not generate ASF License warnings. |
| | | 63m 39s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux fc0dd6901746 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 87620c8d5c45999841336ce077c781481351bea2 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 179 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291850689
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 10s | | branch-2 passed |
| +1 :green_heart: | compile | 5m 58s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 11s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 9m 53s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 4s | | the patch passed |
| +1 :green_heart: | compile | 5m 58s | | the patch passed |
| +1 :green_heart: | javac | 5m 58s | | root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 19s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 10m 21s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 16m 54s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 51s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 30s | | The patch does not generate ASF License warnings. |
| | | 63m 31s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux cebd8a2a8b02 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4549bf2eb224874b77977113678de014ae6124b4 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 182 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2225926965
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 9s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 13s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 23s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 59s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 10s | | the patch passed |
| +1 :green_heart: | compile | 2m 13s | | the patch passed |
| +1 :green_heart: | javac | 2m 13s | | the patch passed |
| -0 :warning: | javadoc | 0m 15s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 58s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 101 unchanged - 0 fixed = 111 total (was 101) |
| +1 :green_heart: | shadedjars | 5m 56s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 231m 42s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 265m 30s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 09ca1ee441dc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/ |
| Max. process+thread count | 5069 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1675693315
##########
hbase-rest/pom.xml:
##########
@@ -358,6 +358,8 @@
</systemPropertyVariables>
</configuration>
</plugin>
+ <!-- The protobuf-maven-plugin and com.google.code.maven-replacer-plugin config
Review Comment:
I will try to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291319243
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 19s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 11s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 26s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 9s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 2m 14s | | the patch passed |
| +1 :green_heart: | javac | 2m 14s | | the patch passed |
| -0 :warning: | javadoc | 0m 14s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 46s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187) |
| +1 :green_heart: | shadedjars | 6m 10s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 242m 53s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 277m 19s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 11dda869f04b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 87620c8d5c45999841336ce077c781481351bea2 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/ |
| Max. process+thread count | 5083 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2340382994
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 4s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 6s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 12s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 38s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 28s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | | the patch passed |
| +1 :green_heart: | compile | 2m 10s | | the patch passed |
| +1 :green_heart: | javac | 2m 10s | | the patch passed |
| -0 :warning: | javadoc | 0m 16s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 2m 0s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101) |
| +1 :green_heart: | shadedjars | 5m 27s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 248m 20s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 282m 11s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux a75c144ead5b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/ |
| Max. process+thread count | 4841 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty merged PR #6075:
URL: https://github.com/apache/hbase/pull/6075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2243263599
The reported javadoc issues are in the generated protobuf code, @Apache9 .
Looking at hbase-protocol, javadoc generation is completely disabled there.
We are also excluding generated file in the report generation javadoc phase, but that's not an option hbase-rest.
Should I add the same exclude settings to the normal (build) javadoc settings in the root pom ?
Or should I override the javadoc plugin config in the hbase-rest module ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1677399511
##########
hbase-rest/pom.xml:
##########
@@ -368,9 +370,17 @@
<goal>compile</goal>
</goals>
<phase>generate-sources</phase>
+ <configuration>
+ <protocArtifact>com.google.protobuf:protoc:${internal.protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
Review Comment:
Yes, we could, but I think that the would hide the difference, and make it even harder to find which version we use where.
All the different protobuf libraries and compilers are hard enough figure out already, the current setup at least gives a clue to whoever tries to decypher it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291101527
I have moved the javadoc exclusions from the report section to the dependencyManagement section, so that they also apply in the build section.
Can you take another look @Apache9 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2224866458
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 19s | | branch-2 passed |
| +1 :green_heart: | compile | 6m 4s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 17s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 10m 5s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 5m 56s | | the patch passed |
| +1 :green_heart: | javac | 5m 56s | | root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 14s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 10m 29s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 8s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not generate ASF License warnings. |
| | | 64m 7s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux 80c610fce765 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 99ad3e28041397bdafb5064f5f79c92544007de2 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 181 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1675731898
##########
hbase-rest/pom.xml:
##########
@@ -358,6 +358,8 @@
</systemPropertyVariables>
</configuration>
</plugin>
+ <!-- The protobuf-maven-plugin and com.google.code.maven-replacer-plugin config
Review Comment:
I have centrilzed the replace plugin.
The protobuf compiler config cannot be centralized, as 2.x uses both protobuf 2.5 and thirdparty compilers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2339773356
rebased to current branch-2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2225290979
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 14s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 13s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 24s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 59s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 2m 12s | | the patch passed |
| +1 :green_heart: | javac | 2m 12s | | the patch passed |
| -0 :warning: | javadoc | 0m 15s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 58s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 101 unchanged - 0 fixed = 111 total (was 101) |
| +1 :green_heart: | shadedjars | 6m 0s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 275m 2s | | root in the patch passed. |
| | | 310m 34s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux cdd666dc3825 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 99ad3e28041397bdafb5064f5f79c92544007de2 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/testReport/ |
| Max. process+thread count | 8791 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2226154029
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 12s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 9s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 40s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 56s | | branch-2 passed |
| +1 :green_heart: | javadoc | 3m 36s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 21s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 21s | | the patch passed |
| +1 :green_heart: | compile | 3m 6s | | the patch passed |
| +1 :green_heart: | javac | 3m 6s | | the patch passed |
| -0 :warning: | javadoc | 0m 20s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 2m 16s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 187 unchanged - 0 fixed = 197 total (was 187) |
| +1 :green_heart: | shadedjars | 8m 35s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 342m 17s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 387m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 20bcb4bbb50f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/ |
| Max. process+thread count | 4847 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2242993127
Please fix the javadoc issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2225313434
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 4s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 3s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 15s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 53s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 54s | | the patch passed |
| +1 :green_heart: | compile | 2m 2s | | the patch passed |
| +1 :green_heart: | javac | 2m 2s | | the patch passed |
| -0 :warning: | javadoc | 0m 14s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 51s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 187 unchanged - 0 fixed = 197 total (was 187) |
| +1 :green_heart: | shadedjars | 5m 51s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 292m 27s | | root in the patch passed. |
| | | 326m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2354b9707424 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 99ad3e28041397bdafb5064f5f79c92544007de2 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/testReport/ |
| Max. process+thread count | 8920 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1675799770
##########
hbase-rest/pom.xml:
##########
@@ -368,9 +370,17 @@
<goal>compile</goal>
</goals>
<phase>generate-sources</phase>
+ <configuration>
+ <protocArtifact>com.google.protobuf:protoc:${internal.protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
Review Comment:
I think the only difference is this configuration? We could introduce a property for this so in hbase-protocol-shade and hbase-reset, we use the new protoc compiler while in hbase-protocol, we use the old one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2292385741
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 3s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 14s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 38s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 30s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 59s | | the patch passed |
| +1 :green_heart: | compile | 2m 10s | | the patch passed |
| +1 :green_heart: | javac | 2m 10s | | the patch passed |
| -0 :warning: | javadoc | 0m 16s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 2m 0s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101) |
| +1 :green_heart: | shadedjars | 5m 32s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 300m 29s | | root in the patch passed. |
| | | 335m 58s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 0e502c43a1de 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4549bf2eb224874b77977113678de014ae6124b4 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/ |
| Max. process+thread count | 9055 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2292407509
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 21s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 10s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 20s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 10s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 5s | | the patch passed |
| +1 :green_heart: | compile | 2m 10s | | the patch passed |
| +1 :green_heart: | javac | 2m 10s | | the patch passed |
| -0 :warning: | javadoc | 0m 14s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 47s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187) |
| +1 :green_heart: | shadedjars | 6m 10s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 315m 44s | | root in the patch passed. |
| | | 351m 23s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 365d2adc94f8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4549bf2eb224874b77977113678de014ae6124b4 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/ |
| Max. process+thread count | 8499 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2225558333
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 41s | | branch-2 passed |
| +1 :green_heart: | compile | 7m 8s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 31s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 10m 9s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 9s | | the patch passed |
| +1 :green_heart: | compile | 6m 8s | | the patch passed |
| +1 :green_heart: | javac | 6m 8s | | root generated 0 new + 1232 unchanged - 1 fixed = 1232 total (was 1233) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 10s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 10m 23s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 2s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 47s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not generate ASF License warnings. |
| | | 66m 3s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux a68e764fbb94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 181 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2339947596
Can you take another look, @Apache9 ?
Are the new javadoc generation changes acceptable ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2226353385
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 9s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 9s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 1s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 15s | | branch-2 passed |
| +1 :green_heart: | javadoc | 3m 6s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 33s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 51s | | the patch passed |
| +1 :green_heart: | compile | 2m 43s | | the patch passed |
| +1 :green_heart: | javac | 2m 43s | | the patch passed |
| -0 :warning: | javadoc | 0m 21s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 2m 21s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84) |
| +1 :green_heart: | shadedjars | 6m 50s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 503m 54s | | root in the patch passed. |
| | | 542m 59s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4cbccc07188c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5d309f1e747eed88dc2af06607366ecece998f6 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/testReport/ |
| Max. process+thread count | 8050 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291305296
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 29s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 20s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 38s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 6s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 15s | | the patch passed |
| +1 :green_heart: | compile | 2m 22s | | the patch passed |
| +1 :green_heart: | javac | 2m 22s | | the patch passed |
| -0 :warning: | javadoc | 0m 15s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 2m 0s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 89 unchanged - 12 fixed = 99 total (was 101) |
| +1 :green_heart: | shadedjars | 6m 7s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 234m 9s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 269m 27s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 811ba6b0c135 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 87620c8d5c45999841336ce077c781481351bea2 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/ |
| Max. process+thread count | 5032 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2291697415
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 2m 31s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt) | root in branch-2 failed. |
| +1 :green_heart: | compile | 1m 44s | | branch-2 passed |
| -0 :warning: | javadoc | 1m 26s | [/branch-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-root.txt) | root in branch-2 failed. |
| +1 :green_heart: | shadedjars | 5m 19s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 21s | | the patch passed |
| +1 :green_heart: | compile | 1m 41s | | the patch passed |
| +1 :green_heart: | javac | 1m 41s | | the patch passed |
| -0 :warning: | javadoc | 0m 14s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 32s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84) |
| +1 :green_heart: | shadedjars | 5m 16s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 412m 54s | | root in the patch passed. |
| | | 442m 45s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 837acfe5a760 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 87620c8d5c45999841336ce077c781481351bea2 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/testReport/ |
| Max. process+thread count | 7885 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2292483357
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 1m 19s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt) | root in branch-2 failed. |
| +1 :green_heart: | compile | 1m 46s | | branch-2 passed |
| -0 :warning: | javadoc | 0m 57s | [/branch-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-root.txt) | root in branch-2 failed. |
| -0 :warning: | javadoc | 0m 9s | [/branch-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-hbase-rest.txt) | hbase-rest in branch-2 failed. |
| +1 :green_heart: | shadedjars | 5m 17s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 20s | | the patch passed |
| +1 :green_heart: | compile | 1m 42s | | the patch passed |
| +1 :green_heart: | javac | 1m 42s | | the patch passed |
| -0 :warning: | javadoc | 1m 32s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-root.txt) | root generated 40 new + 54 unchanged - 0 fixed = 94 total (was 54) |
| -0 :warning: | javadoc | 0m 14s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| +1 :green_heart: | shadedjars | 5m 16s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 410m 5s | | root in the patch passed. |
| | | 438m 0s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7619c89d7655 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4549bf2eb224874b77977113678de014ae6124b4 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/testReport/ |
| Max. process+thread count | 7962 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded . hbase-rest U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on code in PR #6075:
URL: https://github.com/apache/hbase/pull/6075#discussion_r1675686178
##########
hbase-rest/pom.xml:
##########
@@ -358,6 +358,8 @@
</systemPropertyVariables>
</configuration>
</plugin>
+ <!-- The protobuf-maven-plugin and com.google.code.maven-replacer-plugin config
Review Comment:
Could we move this to parent pom too? So we do not need to copy paste it everywhere...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2224696083
Note that is includes duplicating the protobuf generated file shading setup from hbase-shaded-protocol.
Another option is to move the protobuf processing to hbase-shaded-protocol, and avoid doing the shading in two modules. (as done on branch-3+)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2339913292
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 48s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 32s | | branch-2 passed |
| +1 :green_heart: | compile | 6m 10s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 11s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 10m 1s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 11s | | the patch passed |
| +1 :green_heart: | compile | 6m 10s | | the patch passed |
| +1 :green_heart: | javac | 6m 10s | | root generated 0 new + 1237 unchanged - 1 fixed = 1237 total (was 1238) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 32s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | spotbugs | 12m 22s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 18m 36s | | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 28s | | The patch does not generate ASF License warnings. |
| | | 69m 1s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti |
| uname | Linux 23d5e25613ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 178 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2340915710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 48s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 38s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 46s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 59s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 21s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 25s | | the patch passed |
| +1 :green_heart: | compile | 1m 43s | | the patch passed |
| +1 :green_heart: | javac | 1m 43s | | the patch passed |
| -0 :warning: | javadoc | 0m 15s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 33s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk8-hadoop2-check/output/results-javadoc-javadoc-root.txt) | root generated 10 new + 84 unchanged - 0 fixed = 94 total (was 84) |
| +1 :green_heart: | shadedjars | 5m 18s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 415m 54s | | root in the patch passed. |
| | | 447m 49s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 28272bc62f88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/ |
| Max. process+thread count | 8005 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28725 Use thirdparty protobuf for REST interface in HBase 2.x [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6075:
URL: https://github.com/apache/hbase/pull/6075#issuecomment-2340561910
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 1s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 11s | | branch-2 passed |
| +1 :green_heart: | compile | 2m 4s | | branch-2 passed |
| +1 :green_heart: | javadoc | 2m 18s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 56s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 56s | | the patch passed |
| +1 :green_heart: | compile | 2m 5s | | the patch passed |
| +1 :green_heart: | javac | 2m 5s | | the patch passed |
| -0 :warning: | javadoc | 0m 13s | [/results-javadoc-javadoc-hbase-rest.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-hbase-rest.txt) | hbase-rest generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -0 :warning: | javadoc | 1m 46s | [/results-javadoc-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk11-hadoop3-check/output/results-javadoc-javadoc-root.txt) | root generated 36 new + 149 unchanged - 38 fixed = 185 total (was 187) |
| +1 :green_heart: | shadedjars | 5m 50s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 310m 39s | | root in the patch passed. |
| | | 346m 49s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6075 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 52522665afb3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 364afb56f971facf71ebcdc0b26f937476e39765 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/testReport/ |
| Max. process+thread count | 8959 (vs. ulimit of 30000) |
| modules | C: hbase-protocol-shaded hbase-rest . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6075/5/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org