[jira] [Resolved] (TIKA-984) JpegParserTest fails for some locales

["Ray Gauss II (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TIKA-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Gauss II resolved TIKA-984.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

Fixed in 1403139.

I changed slightly from Oliver's patch, leaving a {{String}} constant defining the format in place but creating a new locale-specific {{DecimalFormat}} object in the handler.

Thanks for spotting this and the patch!
                
> JpegParserTest fails for some locales
> -------------------------------------
>
>                 Key: TIKA-984
>                 URL: https://issues.apache.org/jira/browse/TIKA-984
>             Project: Tika
>          Issue Type: Bug
>          Components: parser
>    Affects Versions: 1.2
>            Reporter: Oliver Heger
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: TIKA-984.patch
>
>
> On a German locale I get the following test failures:
> Failed tests:
> testJPEGGeo(org.apache.tika.parser.jpeg.JpegParserTest): expected:<12[.]54321> but was:<12[,]54321>
>   testJPEGGeo2(org.apache.tika.parser.jpeg.JpegParserTest): expected:<51[.]575762> but was:<51[,]575762>
> I can provide a patch to make the test pass, but I wonder whether it is desired that the output depends on the locale. This makes it harder for client applications to evaluate parsing results.
> The cause of the problem seems to be the field {{GEO_DECIMAL_FORMAT}} in class {{ImageMetadataExtractor}}. The formatted strings produced by this object are locale-dependent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira