You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2025/07/03 12:04:11 UTC
[PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
weizhouapache opened a new pull request, #11133:
URL: https://github.com/apache/cloudstack/pull/11133
### Description
This PR fixes the conserve_mode of network offering `DefaultIsolatedNetworkOfferingForVpcNetworks` is still 0 in fresh installation
```
mysql> select conserve_mode from `cloud`.`network_offerings` where name='DefaultIsolatedNetworkOfferingForVpcNetworks'\G
*************************** 1. row ***************************
conserve_mode: 0
1 row in set (0.00 sec)
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2191597393
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid= self.domain.id,
Review Comment:
```suggestion
domainid=self.domain.id,
```
in consistent with other parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187818548
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183286467
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187431181
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187481483
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3044754273
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3045985790
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2191598974
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid= self.domain.id,
+ vpcid= vpc.id
+ )
+ LoadBalancerRule.create(
+ self.apiclient,
+ self.services["lbrule"],
+ ipaddressid=public_ip.ipaddress.id,
+ accountid=self.account.name,
+ vpcid= vpc.id,
+ networkid=ntwk.id,
+ domainid=self.account.domainid)
+
+ # 7) Add Port Forwarding Rule with same Public IP to test conserve mode
+ NATRule.create(
+ self.apiclient,
+ self.virtual_machine,
+ self.services["natrule"],
+ ipaddressid=public_ip.ipaddress.id,
+ vpcid= vpc.id,
Review Comment:
```suggestion
vpcid=vpc.id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3055970465
@weizhouapache a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3100859624
@weizhouapache can you check the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3193339184
<b>[SF] Trillian test result (tid-14065)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56659 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t14065-kvm-ol8.zip
Smoke tests completed. 141 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_13_retrieve_vr_default_files | `Error` | 1.11 | test_diagnostics.py
test_14_retrieve_vr_one_file | `Error` | 1.10 | test_diagnostics.py
test_15_retrieve_ssvm_default_files | `Error` | 1.12 | test_diagnostics.py
test_16_retrieve_ssvm_single_file | `Error` | 1.10 | test_diagnostics.py
test_17_retrieve_cpvm_default_files | `Error` | 1.12 | test_diagnostics.py
test_18_retrieve_cpvm_single_file | `Error` | 1.11 | test_diagnostics.py
test_01_deployVMInSharedNetwork | `Failure` | 423.25 | test_network.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 95.00 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 8.58 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | `Failure` | 7.35 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Failure` | 6.55 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.66 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1.73 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 15.61 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 18.74 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 32.41 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown | `Error` | 33.56 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187263831
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3073022952
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3045983100
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3038309075
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3055964446
@blueorangutan LLtest keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3045201532
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183761380
<b>[SF] Trillian Build Failed (tid-14058)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3044608145
@DaanHoogland @sureshanaparti
I updated a smoke test to test the conserve mode, hope the issue will be fixed PERMANENTLY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3032038034
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 3.90%. Comparing base [(`be22bfe`)](https://app.codecov.io/gh/apache/cloudstack/commit/be22bfe2c9d4529726a00d35b45f06551ccc310f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4543df7`)](https://app.codecov.io/gh/apache/cloudstack/commit/4543df74918aae20f33dd41ba38b36a4cdf531dc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (be22bfe) and HEAD (4543df7). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (be22bfe) | HEAD (4543df7) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11133 +/- ##
=============================================
- Coverage 16.57% 3.90% -12.68%
=============================================
Files 5743 414 -5329
Lines 510648 33751 -476897
Branches 62105 6077 -56028
=============================================
- Hits 84641 1317 -83324
+ Misses 416534 32276 -384258
+ Partials 9473 158 -9315
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11133/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11133/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.90% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11133/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11133?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3032366782
> clgtm, and would this be the last one? ;)
hope so @DaanHoogland
:laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3047955170
<b>[SF] Trillian test result (tid-13707)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52938 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t13707-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_network_acl | `Error` | 111.36 | test_network_acl.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2185221292
##########
engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql:
##########
@@ -203,3 +203,6 @@ SET `sort_key` = CASE
ELSE `sort_key`
END;
-- End: Changes for Guest OS category cleanup
+
+-- Re-apply VPC: update default network offering for vpc tier to conserve_mode=1 (#8309)
+UPDATE `cloud`.`network_offerings` SET conserve_mode=1 WHERE name='DefaultIsolatedNetworkOfferingForVpcNetworks';
Review Comment:
```suggestion
UPDATE `cloud`.`network_offerings` SET conserve_mode = 1 WHERE name = 'DefaultIsolatedNetworkOfferingForVpcNetworks';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3036031403
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3044760753
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187260331
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183629871
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3190334030
<b>[SF] Trillian test result (tid-14060)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52118 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t14060-kvm-ol8.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_13_retrieve_vr_default_files | `Error` | 1.12 | test_diagnostics.py
test_14_retrieve_vr_one_file | `Error` | 1.11 | test_diagnostics.py
test_15_retrieve_ssvm_default_files | `Error` | 1.11 | test_diagnostics.py
test_16_retrieve_ssvm_single_file | `Error` | 1.11 | test_diagnostics.py
test_17_retrieve_cpvm_default_files | `Error` | 1.12 | test_diagnostics.py
test_18_retrieve_cpvm_single_file | `Error` | 1.12 | test_diagnostics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 408.46 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183623661
@blueorangutan test ol8 kvm-ol8 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3187475974
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2191598584
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid= self.domain.id,
+ vpcid= vpc.id
+ )
+ LoadBalancerRule.create(
+ self.apiclient,
+ self.services["lbrule"],
+ ipaddressid=public_ip.ipaddress.id,
+ accountid=self.account.name,
+ vpcid= vpc.id,
Review Comment:
```suggestion
vpcid=vpc.id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2191597636
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid= self.domain.id,
+ vpcid= vpc.id
Review Comment:
```suggestion
vpcid=vpc.id
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3044605822
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3032016652
I am so sorry, this is the 3rd PR for the same issue
:facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3040334364
<b>[SF] Trillian test result (tid-13687)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52969 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t13687-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3038312746
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183289904
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3183564112
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2275717588
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid=self.domain.id,
+ vpcid=vpc.id
+ )
+ LoadBalancerRule.create(
+ self.apiclient,
+ self.services["lbrule"],
+ ipaddressid=public_ip.ipaddress.id,
+ accountid=self.account.name,
+ vpcid=vpc.id,
+ networkid=ntwk.id,
+ domainid=self.account.domainid)
+
+ # 7) Add Port Forwarding Rule with same Public IP to test conserve mode
+ NATRule.create(
+ self.apiclient,
+ self.virtual_machine,
Review Comment:
```suggestion
vm,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3190709975
> [SF] Trillian test result (tid-14060) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52118 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t14060-kvm-ol8.zip Smoke tests completed. 144 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
> test_13_retrieve_vr_default_files `Error` 1.12 test_diagnostics.py
> test_14_retrieve_vr_one_file `Error` 1.11 test_diagnostics.py
> test_15_retrieve_ssvm_default_files `Error` 1.11 test_diagnostics.py
> test_16_retrieve_ssvm_single_file `Error` 1.11 test_diagnostics.py
> test_17_retrieve_cpvm_default_files `Error` 1.12 test_diagnostics.py
> test_18_retrieve_cpvm_single_file `Error` 1.12 test_diagnostics.py
> test_01_redundant_vpc_site2site_vpn `Failure` 408.46 test_vpc_vpn.py
smoke test failure with `test_network_acl` is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti merged PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#discussion_r2191597393
##########
test/integration/smoke/test_network_acl.py:
##########
@@ -125,6 +125,32 @@ def test_network_acl(self):
self.assertTrue(vm.state == 'Running', "VM is not running")
self.debug("VM %s deployed in VPC %s" %(vm.id, vpc.id))
+ # 6) Acquire a Public IP, and add Load Balancing Rule
+ public_ip = PublicIPAddress.create(
+ self.apiclient,
+ zoneid=self.zone.id,
+ accountid=self.account.name,
+ domainid= self.domain.id,
Review Comment:
```suggestion
domainid=self.domain.id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3036673144
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11133:
URL: https://github.com/apache/cloudstack/pull/11133#issuecomment-3036038418
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org