You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lingsamuel (via GitHub)" <gi...@apache.org> on 2023/03/08 01:08:18 UTC
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request, #1715: bugfix: fix secret created later than apisixtls
lingsamuel opened a new pull request, #1715:
URL: https://github.com/apache/apisix-ingress-controller/pull/1715
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [x] Bugfix
### What this PR does / why we need it:
Fixes #1190
Cache `ApisixTls -> Secret` relationship even if the translation failed. This can fix secret created later than ApisixTls case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1715: bugfix: fix secret created later than apisixtls
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1715:
URL: https://github.com/apache/apisix-ingress-controller/pull/1715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1715: bugfix: fix secret created later than apisixtls
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1715:
URL: https://github.com/apache/apisix-ingress-controller/pull/1715#issuecomment-1459767884
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1715?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1715?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (878c350) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/7d62b7e45463b6f70ad5585ba2cf745a2fe07824?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d62b7e) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 878c350 differs from pull request most recent head b5d3ae6. Consider uploading reports for the commit b5d3ae6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
=======================================
Coverage 41.48% 41.49%
=======================================
Files 89 89
Lines 7667 7668 +1
=======================================
+ Hits 3181 3182 +1
Misses 4122 4122
Partials 364 364
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `83.05% <100.00%> (+0.14%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1715: bugfix: fix secret created later than apisixtls
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1715:
URL: https://github.com/apache/apisix-ingress-controller/pull/1715#issuecomment-1459249895
please check failed jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org