You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/07 17:09:45 UTC

[GitHub] zheng-da commented on a change in pull request #10021: [WIP] [MXNET-33] Mkldnn pooling convention crash

zheng-da commented on a change in pull request #10021: [WIP] [MXNET-33] Mkldnn pooling convention crash
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r172915279
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
 ##########
 @@ -92,6 +92,8 @@ inline bool SupportMKLDNNPooling(const PoolingParam &param,
 
   if (param.pooling_convention == pool_enum::kValid)
     return true;
+  else
+    return false;
 
 Review comment:
   maybe use "#if 0" to comment the checks below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services