[GitHub] [doris] xinyiZzz commented on a diff in pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed

[GitBox <gi...@apache.org>]

xinyiZzz commented on code in PR #14840:
URL: https://github.com/apache/doris/pull/14840#discussion_r1040334273


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -510,7 +510,10 @@ void FragmentMgr::_exec_actual(std::shared_ptr<FragmentExecState> exec_state, Fi
         std::lock_guard<std::mutex> lock(_lock);
         _fragment_map.erase(exec_state->fragment_instance_id());
         if (all_done && fragments_ctx) {
-            _fragments_ctx_map.erase(fragments_ctx->query_id);
+            auto search = _fragments_ctx_map.find(fragments_ctx->query_id);

Review Comment:
   Indeed, fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org