You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/16 16:27:42 UTC
[GitHub] Antonio-Maranhao opened a new pull request #1159: Remove chai
dependency
Antonio-Maranhao opened a new pull request #1159: Remove chai dependency
URL: https://github.com/apache/couchdb-fauxton/pull/1159
## Overview
Removes all uses of Chai's `assert` in favor of Jest's built-in `expect` matchers. This makes the test code more consistent instead of having a mix of `expect` and `assert` calls.
Most of the code changes were done using a codemod: https://github.com/skovhus/jest-codemods.
As a bonus, I fixed a few tests that were wrong (always passing) and re-enabled most skipped tests (there's only 1 skipped test now - yay!)
## Testing recommendations
Run Jest as usual
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services