You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/11 03:40:56 UTC
[GitHub] [avro] yurybubnov opened a new pull request, #1818: AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader
yurybubnov opened a new pull request, #1818:
URL: https://github.com/apache/avro/pull/1818
**Support Map(with non-String keys) and Set in ReflectDatumReader**
### Jira
My PR addresses the following [AVRO-3602](https://issues.apache.org/jira/browse/AVRO-3602) issues
### Tests
My PR adds the following unit tests:
TestReflectDatumReader.testRead_PojoWithSet
TestReflectDatumReader.testRead_PojoWithMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1818: AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1818:
URL: https://github.com/apache/avro/pull/1818#issuecomment-1227059219
@thiru-mg You should also close the respective JIRA after merging PRs.
Since the PR does not introduce backward incompatible changes it should probably be ported back to `branch-1.11` too ?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1818: AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1818:
URL: https://github.com/apache/avro/pull/1818#issuecomment-1228334101
@yurybubnov A separate MR is not really needed. We could easily cherry-pick the squashed commit from master/1.12.0.
Let me do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] yurybubnov commented on pull request #1818: AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader
Posted by GitBox <gi...@apache.org>.
yurybubnov commented on PR #1818:
URL: https://github.com/apache/avro/pull/1818#issuecomment-1227626436
@martin-g @thiru-mg I created backport [MR](https://github.com/apache/avro/pull/1838) for 1.11 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] thiru-mg merged pull request #1818: AVRO-3602 Support Map(with non-String keys) and Set in ReflectDatumReader
Posted by GitBox <gi...@apache.org>.
thiru-mg merged PR #1818:
URL: https://github.com/apache/avro/pull/1818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org