You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rp...@apache.org on 2016/02/24 00:21:35 UTC
[47/50] logging-log4j2 git commit: fix spuriously failing test
fix spuriously failing test
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/83604ecd
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/83604ecd
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/83604ecd
Branch: refs/heads/LOG4J2-1278-gc-free-logger
Commit: 83604ecdc9b46c0987c1eb920a34c63772f513fb
Parents: bb38736
Author: rpopma <rp...@apache.org>
Authored: Wed Feb 24 04:56:24 2016 +0900
Committer: rpopma <rp...@apache.org>
Committed: Wed Feb 24 04:56:24 2016 +0900
----------------------------------------------------------------------
.../RollingRandomAccessFileAppenderRolloverTest.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/83604ecd/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java
index 702afa6..a58975b 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppenderRolloverTest.java
@@ -67,6 +67,8 @@ public class RollingRandomAccessFileAppenderRolloverTest {
final String trigger = "This message triggers rollover.";
log.warn(trigger);
+ Thread.sleep(100);
+ log.warn(trigger);
CoreLoggerContexts.stopLoggerContext(); // stop async thread
CoreLoggerContexts.stopLoggerContext(false); // stop async thread
@@ -91,7 +93,11 @@ public class RollingRandomAccessFileAppenderRolloverTest {
assertTrue("renamed file line 1", old1.contains(msg));
final String old2 = reader.readLine();
assertTrue("renamed file line 2", old2.contains(exceed));
- final String line = reader.readLine();
+ String line = reader.readLine();
+ if (line != null) {
+ assertTrue("strange...", line.contains("This message triggers rollover."));
+ line = reader.readLine();
+ }
assertNull("No more lines", line);
reader.close();
after1.delete();