You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/11/02 16:30:35 UTC

[Impala-ASF-CR] IMPALA-9180 (part 3): Remove legacy backend port

Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16533 )

Change subject: IMPALA-9180 (part 3): Remove legacy backend port
......................................................................

IMPALA-9180 (part 3): Remove legacy backend port

The legacy Thrift based Impala internal service has been removed so
the backend port 22000 can be freed up.

This patch set flag be_port as a REMOVED_FLAG and all infrastructures
around it are cleaned up. StatestoreSubscriber::subscriber_id is set
as hostname + krpc_port.

Testing:
 - Passed the exhaustive test.
 - Did manually testing on a dev cluster, verified that CM with fixing
   work with new version of Impala, which set subscriber_id as hostname
   + krpc_port. Verified the subscriber_ids of Impalad in Statestore Web
   Server. The health check of Impala cluster on CM worked as expected.
 - Passed CDH L0 test on cdpd-master branch.

Change-Id: Ic6909a8da449b4d25ee98037b3eb459af4850dc6
---
M be/src/common/global-flags.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/data-stream-test.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/scheduling/schedule-state.h
M be/src/scheduling/scheduler.cc
M bin/start-impala-cluster.py
M common/protobuf/admission_control_service.proto
M common/protobuf/control_service.proto
M common/protobuf/statestore_service.proto
M infra/deploy/deploy.py
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_query_retries.py
M tests/shell/test_shell_interactive.py
16 files changed, 27 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/16533/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6909a8da449b4d25ee98037b3eb459af4850dc6
Gerrit-Change-Number: 16533
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>