You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/01 11:19:56 UTC

[GitHub] [dolphinscheduler] 106umao opened a new pull request, #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…

106umao opened a new pull request, #10329:
URL: https://github.com/apache/dolphinscheduler/pull/10329

   …rsion.
   
   Modified the Hardware Environment，Standalone Deployement, Pseudo Cluster Deployment documentaton.
   
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10329:
URL: https://github.com/apache/dolphinscheduler/pull/10329#discussion_r915494093


##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -8,7 +8,7 @@ If you are a new hand and want to experience DolphinScheduler functions, we reco
 
 Pseudo-cluster deployment of DolphinScheduler requires external software support:
 
-* JDK：Download [JDK][jdk] (1.8+), and configure `JAVA_HOME` to and `PATH` variable. You can skip this step, if it already exists in your environment.
+* JDK：Download [JDK][jdk] (1.8.x), and configure `JAVA_HOME` to and `PATH` variable. You can skip this step if it already exists in your environment.If it is not clear why `JDK1.8.x` is required, please refer to [Hardware Environment](https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/about/hardware.html)

Review Comment:
   So, please change this, we currently supported jdk 11 too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10329:
URL: https://github.com/apache/dolphinscheduler/pull/10329#issuecomment-1177044909

   > @ruanwenjun do we support java 11 now?
   
   Yes, we support, we will run the process to build/UT with jdk11 in our CI. But when user use idk 11 in idea he still need do a extra config, I think this is idea's issue :).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] 106umao closed pull request #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…

Posted by GitBox <gi...@apache.org>.
106umao closed pull request #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…
URL: https://github.com/apache/dolphinscheduler/pull/10329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10329: [Feature][Doc] Makes it easier for developers to determine the JDK ve…

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10329:
URL: https://github.com/apache/dolphinscheduler/pull/10329#issuecomment-1177002163

   @ruanwenjun do we support java 11 now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org