[jira] Issue Comment Edited: (DERBY-4895) Thread local TableDescriptor#referencedColumnMap is not set to null when connection closes.

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930586#action_12930586 ] 

Dag H. Wanvik edited comment on DERBY-4895 at 11/10/10 7:50 AM:
----------------------------------------------------------------

Uploading a patch which replaces the thread local storage of the referencedColumnMap in favor of storing it in the lcc.  This should solve the problem seen by the user.
If several threads use the same connection, they will now share the referencedColumnMap, but the API calls are serialized at the JDBC level, so that's ok.
If a thread uses several connections, there will now be one map per connection, which is ok, too.

Regressions ran ok.


      was (Author: dagw):
    Uploading a patch which replaces the thread local storage of the referenceColumnMap in favor of storing it in the lcc.  This should solve the problem seen by the user.
If several threads use the same connection, they will now share the referenceColumnMap, but they API calls are serialized at the JDBC level, so that's ok.
If a thread uses several connections, there will now be one map per connection, which is ok, too.

Regressions ran ok.

  
> Thread local TableDescriptor#referencedColumnMap is not set to null when connection closes.
> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4895
>                 URL: https://issues.apache.org/jira/browse/DERBY-4895
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0, 10.6.2.1
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: derby-4895-a.diff, derby-4895-a.stat
>
>
> > This has been seen to cause error messages in TomCat, cf. this quote from a mail on derby-user:
> > 
> > http://mail-archives.apache.org/mod_mbox/db-derby-user/201011.mbox/%3C7800E37B639BC345BC2AB40980B7C529180FB525@MERCMBX03R.na.SAS.com%3E
> > 
> > SEVERE: The web application [/MyApp] created a ThreadLocal with key of type [org.apache.derby.iapi.sq\
> > l.dictionary.TableDescriptor$1] (value [org.apache.derby.iapi.sql.dictionary.TableDescriptor$1@d133a3])\
> >  and a value of type [java.util.WeakHashMap] (value [{={1, 2, 3, 4}, =null, =null}]) but failed to remo\
> > ve it when the web application was stopped. This is very likely to create a memory leak.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.