[GitHub] bfach10 commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation

[GitBox <gi...@apache.org>]

bfach10 commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation
URL: https://github.com/apache/accumulo/pull/347#discussion_r159700019
 
 

 ##########
 File path: core/src/test/java/org/apache/accumulo/core/data/MutationTest.java
 ##########
 @@ -187,7 +187,8 @@ private Value nv(String s) {
   public void testPuts() {
     Mutation m = new Mutation(new Text("r1"));
 
-    m.put(nt("cf1"), nt("cq1"), nv("v1"));
+    m.at().family(nt("cf1")).qualifier(nt("cq1")).set(nv("v1"));
 
 Review comment:
   For sure needs more testing. I'm going to try out the design of having the `set()` methods return `Mutation` in this next commit, in addition to more tests. Thank you for the great start you've given me here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services