You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/03/17 17:18:19 UTC
Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When
fetching string attribute with null value returns null ,
earlier versions returned empty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/
-----------------------------------------------------------
(Updated March 17, 2021, 5:18 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4211
https://issues.apache.org/jira/browse/ATLAS-4211
Repository: atlas
Description
-------
For TraversalBasedExecutor which is default executor, values:[[""]] is replaced to values: [[null]] whenever there is null value for any of attributes in Select Clause
Diffs
-----
repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java 7018c1578
Diff: https://reviews.apache.org/r/73233/diff/1/
Testing (updated)
-------
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/456/console
Thanks,
Pinal Shah
Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When
fetching string attribute with null value returns null ,
earlier versions returned empty
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/#review222698
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java
Line 134 (original), 134 (patched)
<https://reviews.apache.org/r/73233/#comment311864>
Replace "" with StringUtils.EMPTY to be consistent with rest of the code.
- Ashutosh Mestry
On March 17, 2021, 5:18 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73233/
> -----------------------------------------------------------
>
> (Updated March 17, 2021, 5:18 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4211
> https://issues.apache.org/jira/browse/ATLAS-4211
>
>
> Repository: atlas
>
>
> Description
> -------
>
> For TraversalBasedExecutor which is default executor, values:[[""]] is replaced to values: [[null]] whenever there is null value for any of attributes in Select Clause
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java 7018c1578
>
>
> Diff: https://reviews.apache.org/r/73233/diff/1/
>
>
> Testing
> -------
>
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/456/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When
fetching string attribute with null value returns null ,
earlier versions returned empty
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/#review222696
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On March 17, 2021, 10:18 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73233/
> -----------------------------------------------------------
>
> (Updated March 17, 2021, 10:18 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4211
> https://issues.apache.org/jira/browse/ATLAS-4211
>
>
> Repository: atlas
>
>
> Description
> -------
>
> For TraversalBasedExecutor which is default executor, values:[[""]] is replaced to values: [[null]] whenever there is null value for any of attributes in Select Clause
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java 7018c1578
>
>
> Diff: https://reviews.apache.org/r/73233/diff/1/
>
>
> Testing
> -------
>
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/456/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When
fetching string attribute with null value returns null ,
earlier versions returned empty
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/#review222705
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On March 18, 2021, 8:52 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73233/
> -----------------------------------------------------------
>
> (Updated March 18, 2021, 8:52 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4211
> https://issues.apache.org/jira/browse/ATLAS-4211
>
>
> Repository: atlas
>
>
> Description
> -------
>
> For TraversalBasedExecutor which is default executor, values:[[""]] is replaced to values: [[null]] whenever there is null value for any of attributes in Select Clause
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java 7018c1578
>
>
> Diff: https://reviews.apache.org/r/73233/diff/2/
>
>
> Testing
> -------
>
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/456/console
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When
fetching string attribute with null value returns null ,
earlier versions returned empty
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/
-----------------------------------------------------------
(Updated March 18, 2021, 3:52 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
addressed review comment
Bugs: ATLAS-4211
https://issues.apache.org/jira/browse/ATLAS-4211
Repository: atlas
Description
-------
For TraversalBasedExecutor which is default executor, values:[[""]] is replaced to values: [[null]] whenever there is null value for any of attributes in Select Clause
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java 7018c1578
Diff: https://reviews.apache.org/r/73233/diff/2/
Changes: https://reviews.apache.org/r/73233/diff/1-2/
Testing
-------
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/456/console
Thanks,
Pinal Shah