You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/01/16 18:31:49 UTC

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9036


Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................

IMPALA-6377: Bump breakpad version to include fix for #752

This also removes the PPC patches from Breakpad, which I was not able to
get to apply cleanly.

Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
---
M buildall.sh
A source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
2 files changed, 78 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/36/9036/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 )

Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................


Patch Set 2: Verified+1 Code-Review+2

(3 comments)

Carrying Sailesh's +2, verified in a private build.

http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@7
PS1, Line 7: #752
> Could you add a link for this?
Done


http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@8
PS1, Line 8: 
> Not sure if you do this on every version bump, but it would be good to incl
I added a note. Copying patches over for new versions seems to be a common pattern in the toolchain.


http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@9
PS1, Line 9: This change bumps the Breakpad version in the toolchain to pull in the
           : fix for https://bugs.
> Add that the PPC patch will get re-added in a later commit, after the patch
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jan 2018 22:02:55 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9036

to look at the new patch set (#2).

Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................

IMPALA-6377: Bump breakpad version to include fix for #752

This change bumps the Breakpad version in the toolchain to pull in the
fix for https://bugs.chromium.org/p/google-breakpad/issues/detail?id=752 .

It also copies the DWZ patch required for IMPALA-4227 to be applied to
the new version.

This change also removes the PPC patches from Breakpad, which I was not
able to get to apply cleanly. They will be re-applied in a later change.

Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
---
M buildall.sh
A source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
2 files changed, 78 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/36/9036/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 )

Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

Just a few nits.

http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@7
PS1, Line 7: #752
Could you add a link for this?


http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@8
PS1, Line 8: 
Not sure if you do this on every version bump, but it would be good to include a link to the JIRA regarding the DWZ patch, and just say that you're re-applying it for the new version.


http://gerrit.cloudera.org:8080/#/c/9036/1//COMMIT_MSG@9
PS1, Line 9: This also removes the PPC patches from Breakpad, which I was not able to
           : get to apply cleanly.
Add that the PPC patch will get re-added in a later commit, after the patch is fixed for the latest version.



-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jan 2018 21:54:56 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9036 )

Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................


Patch Set 1:

I tested this in a private build.


-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jan 2018 18:32:16 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-6377: Bump breakpad version to include fix for #752

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9036 )

Change subject: IMPALA-6377: Bump breakpad version to include fix for #752
......................................................................

IMPALA-6377: Bump breakpad version to include fix for #752

This change bumps the Breakpad version in the toolchain to pull in the
fix for https://bugs.chromium.org/p/google-breakpad/issues/detail?id=752 .

It also copies the DWZ patch required for IMPALA-4227 to be applied to
the new version.

This change also removes the PPC patches from Breakpad, which I was not
able to get to apply cleanly. They will be re-applied in a later change.

Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
---
M buildall.sh
A source/breakpad/breakpad-97a98836768f8f0154f8f86e5e14c2bb7e74132e-patches/0001-Add-basic-support-for-dwz-dwarf-extension.patch
2 files changed, 78 insertions(+), 1 deletion(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6212ab77eff2df0cb51339c25183ae4f22b07b
Gerrit-Change-Number: 9036
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>