[jira] [Work logged] (HIVE-25878) Unable to compile cpp metastore thrift client

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25878?focusedWorklogId=711370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711370 ]

ASF GitHub Bot logged work on HIVE-25878:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jan/22 12:47
            Start Date: 19/Jan/22 12:47
    Worklog Time Spent: 10m 
      Work Description: kasakrisz opened a new pull request #2953:
URL: https://github.com/apache/hive/pull/2953


   ### What changes were proposed in this pull request?
   Thrift generates cpp client with structs/classes having non-pointer fields. This blocks forward declaration.
   However `SourceTable` is referenced from `CreationMetadata` as a collection element type which makes thrift to generate a pointer type for `SourceTable`. To resolve the circular dependency issue move `SourceTable` definition after `Table` definition in hive_metastore.thrift.
   Also change the collection type `set<SourceTable>` to list<SourceTable> because set requires additional changes on the element type.
   
   ### Why are the changes needed?
   Fix compilation errors in cpp thrift metastore client. 
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Compile the cpp client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 711370)
    Remaining Estimate: 0h
            Time Spent: 10m

> Unable to compile cpp metastore thrift client
> ---------------------------------------------
>
>                 Key: HIVE-25878
>                 URL: https://issues.apache.org/jira/browse/HIVE-25878
>             Project: Hive
>          Issue Type: Bug
>          Components: Thrift API
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HIVE-25656 introduced struct {{SourceTable}} into the metastore Thrift API.
> The following structs definition contains circular dependency:
> {code:java}
> struct SourceTable {
>     1: required Table table,
>    ...
> }
> struct CreationMetadata {
>     ...
>     7: optional set<SourceTable> sourceTables
> }
> struct Table {
>   ...
>   16: optional CreationMetadata creationMetadata,   // only for MVs, it stores table names used and txn list at MV creation
>   ...
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)