You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/05 13:05:57 UTC

[GitHub] [arrow] davisusanibar opened a new pull request, #13072: ARROW-16328: [Java] Initial draft to experiment with java module system

davisusanibar opened a new pull request, #13072:
URL: https://github.com/apache/arrow/pull/13072

   Proposal to upgrade Arrow Java to [Module System](https://openjdk.java.net/jeps/261).
   
   Planning:
   
   - [x] Migrate Arrow Java Format
   - [x] Migrate Arrow Java Memory Core
   - [ ] Migrate Arrow Java Memory Netty
   - [ ] Migrate Arrow Java Memory Unsafe
   - [ ] Migrate Arrow Java Vector
   - [ ] Migrate Arrow Java Flight
   
   Current issues:
   - Package 'io.netty.buffer' exists in another module: io.netty.buffer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] martin-g commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r881592518


##########
java/memory/memory-netty/pom.xml:
##########
@@ -69,4 +70,25 @@
       </build>
     </profile>
   </profiles>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <configuration>
+          <compilerArgs combine.children="append">
+            <arg>--patch-module=io.netty.buffer=/Users/dsusanibar/.m2/repository/org/apache/arrow/memory-netty-buffer-patch/8.0.0-SNAPSHOT/memory-netty-buffer-patch-8.0.0-SNAPSHOT.jar</arg>

Review Comment:
   Use ` ${settings.localRepository}` instead of hardcoding the user



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] davisusanibar commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1731904205

   > @danepitkin: In case it's applicable here, I recently noticed RoaringBitmap upgraded to JPMS w/o needing to drop support for Java 8, see [RoaringBitmap/RoaringBitmap#657](https://github.com/RoaringBitmap/RoaringBitmap/pull/657). It looks like it requires dropping support for _building_ with Java 8 (must be built with Java 11+) but the result can still be run under Java 8. I'm not familiar with a lot of the details so I can't say if this same approach would help here but I thought I'd share.
   
   Hi Team, yes, there are some solutions available for implementing JPMS ad target/release to JDK8, the main problem is that these solutions will fail if a project has Unsafe dependencies. Consider: https://github.com/apache/arrow/pull/13072#:~:text=Implement%20cross%2Dcompilation,jeps/247 and [JEP-247](https://openjdk.org/jeps/247#:~:text=For%20N%20%3E%3D%209%2C%20the,image%20is%20not%20allowed.).
   
   The PR was moved around to include module-info.java files **to validate only JPMS requirements** and ensure that we are prepared to implement them after JDK8 deprecation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] amol- closed pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- closed pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System
URL: https://github.com/apache/arrow/pull/13072


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1814991745

   Hey @mmendonca2 , I added an update to the issue you linked. In summary, the Arrow community decided not to deprecate Java 8 support for the foreseeable future. The plan is to revisit that discussion around 2024-06.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13072: ARROW-16328: [Java] Initial draft to experiment with java module system

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1118525336

   https://issues.apache.org/jira/browse/ARROW-16328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] martin-g commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r881593606


##########
java/pom.xml:
##########
@@ -28,18 +28,21 @@
   <url>https://arrow.apache.org/</url>
 
   <properties>
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
     <target.gen.source.path>${project.build.directory}/generated-sources</target.gen.source.path>
     <dep.junit.platform.version>1.4.0</dep.junit.platform.version>
     <dep.junit.jupiter.version>5.4.0</dep.junit.jupiter.version>
-    <dep.slf4j.version>1.7.25</dep.slf4j.version>
+    <dep.slf4j.version>1.7.36</dep.slf4j.version>
     <dep.guava.version>30.1.1-jre</dep.guava.version>
-    <dep.netty.version>4.1.72.Final</dep.netty.version>
     <dep.jackson-bom.version>2.13.2.20220328</dep.jackson-bom.version>
+    <dep.netty.version>4.1.76.Final</dep.netty.version>
+    <dep.netty-bom.version>4.1.76.Final</dep.netty-bom.version>
     <dep.hadoop.version>2.7.1</dep.hadoop.version>
     <dep.fbs.version>1.12.0</dep.fbs.version>
     <dep.avro.version>1.10.0</dep.avro.version>
     <arrow.vector.classifier />
-    <forkCount>2</forkCount>
+    <forkCount>0</forkCount>

Review Comment:
   Is this related to JPMS ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] davisusanibar commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r994133034


##########
java/pom.xml:
##########
@@ -28,18 +28,21 @@
   <url>https://arrow.apache.org/</url>
 
   <properties>
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
     <target.gen.source.path>${project.build.directory}/generated-sources</target.gen.source.path>
     <dep.junit.platform.version>1.4.0</dep.junit.platform.version>
     <dep.junit.jupiter.version>5.4.0</dep.junit.jupiter.version>
-    <dep.slf4j.version>1.7.25</dep.slf4j.version>
+    <dep.slf4j.version>1.7.36</dep.slf4j.version>
     <dep.guava.version>30.1.1-jre</dep.guava.version>
-    <dep.netty.version>4.1.72.Final</dep.netty.version>
     <dep.jackson-bom.version>2.13.2.20220328</dep.jackson-bom.version>
+    <dep.netty.version>4.1.76.Final</dep.netty.version>
+    <dep.netty-bom.version>4.1.76.Final</dep.netty-bom.version>
     <dep.hadoop.version>2.7.1</dep.hadoop.version>
     <dep.fbs.version>1.12.0</dep.fbs.version>
     <dep.avro.version>1.10.0</dep.avro.version>
     <arrow.vector.classifier />
-    <forkCount>2</forkCount>
+    <forkCount>0</forkCount>

Review Comment:
   Updated to 2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jdimeo commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "jdimeo (via GitHub)" <gi...@apache.org>.
jdimeo commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1556068647

   It's 100% still relevant. What's preventing the merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] amol- commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "amol- (via GitHub)" <gi...@apache.org>.
amol- commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1490666967

   Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r1407385966


##########
java/memory/memory-netty/pom.xml:
##########
@@ -68,5 +75,25 @@
         </plugins>
       </build>
     </profile>
+
+    <profile>
+      <id>memory-jdk11+</id>
+      <activation>
+        <jdk>[11,]</jdk>
+      </activation>
+            <build>
+              <plugins>
+                <plugin>
+                  <groupId>org.apache.maven.plugins</groupId>
+                  <artifactId>maven-compiler-plugin</artifactId>
+                  <configuration>
+                    <compilerArgs combine.children="append">
+                      <arg>--patch-module=io.netty.buffer=${project.basedir}/../memory-netty-buffer-patch/target/arrow-memory-netty-buffer-patch-${project.version}.jar</arg>

Review Comment:
   @davisusanibar , I'm having problems getting this step to run in the new PR and am not entirely sure if it is necessary.
   
   The new PR just does a pure syntax compilation of module-info.java so it doesn't verify the dependencies listed and just uses the classpath to look for classes from arrow-memory-netty-buffer-patch.
   
   Was this step added so that this module would correctly find classes in io.netty.buffer defined in arrow-memory-netty-buffer-patch at build-time only, or does this have an effect at run time? My reading online is that even if we used patch-module to compile, a user utilizing the module would still need to use patch-module to specify module extensions to netty.
   
   If patch-module is only used here to help get this JAR to compile, it seems like it isn't necessary in the new PR since the plugin is compiling module-info.java without verifying its imports.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] davisusanibar commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r984532591


##########
java/pom.xml:
##########
@@ -28,18 +28,21 @@
   <url>https://arrow.apache.org/</url>
 
   <properties>
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
     <target.gen.source.path>${project.build.directory}/generated-sources</target.gen.source.path>
     <dep.junit.platform.version>1.4.0</dep.junit.platform.version>
     <dep.junit.jupiter.version>5.4.0</dep.junit.jupiter.version>
-    <dep.slf4j.version>1.7.25</dep.slf4j.version>
+    <dep.slf4j.version>1.7.36</dep.slf4j.version>
     <dep.guava.version>30.1.1-jre</dep.guava.version>
-    <dep.netty.version>4.1.72.Final</dep.netty.version>
     <dep.jackson-bom.version>2.13.2.20220328</dep.jackson-bom.version>
+    <dep.netty.version>4.1.76.Final</dep.netty.version>
+    <dep.netty-bom.version>4.1.76.Final</dep.netty-bom.version>
     <dep.hadoop.version>2.7.1</dep.hadoop.version>
     <dep.fbs.version>1.12.0</dep.fbs.version>
     <dep.avro.version>1.10.0</dep.avro.version>
     <arrow.vector.classifier />
-    <forkCount>2</forkCount>
+    <forkCount>0</forkCount>

Review Comment:
   To be reviewed. Value more than "0" produce: NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] amoeba commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1731810618

   @danepitkin: In case it's applicable here, I recently noticed RoaringBitmap upgraded to JPMS w/o needing to drop support for Java 8, see https://github.com/RoaringBitmap/RoaringBitmap/pull/657. It looks like it requires dropping support for _building_ with Java 8 (must be built with Java 11+) but the result can still be run under Java 8. I'm not familiar with a lot of the details so I can't say if this same approach would help here but I thought I'd share.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] davisusanibar commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r984532112


##########
java/memory/memory-netty/pom.xml:
##########
@@ -69,4 +70,25 @@
       </build>
     </profile>
   </profiles>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <configuration>
+          <compilerArgs combine.children="append">
+            <arg>--patch-module=io.netty.buffer=/Users/dsusanibar/.m2/repository/org/apache/arrow/memory-netty-buffer-patch/8.0.0-SNAPSHOT/memory-netty-buffer-patch-8.0.0-SNAPSHOT.jar</arg>

Review Comment:
   Thanks, updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jdglaser commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "jdglaser (via GitHub)" <gi...@apache.org>.
jdglaser commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1412200054

   Any chance this can be 
   
   > This looks like it's ready for review! Can we get it merged so that we can get Snowflake JDBC working with Java 17? [snowflakedb/snowflake-jdbc#589](https://github.com/snowflakedb/snowflake-jdbc/issues/589)
   
   Any update on this? Our team is also looking to have the Snowflake JDBC working with Java 17.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] json-warner commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "json-warner (via GitHub)" <gi...@apache.org>.
json-warner commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1457891390

   > > This looks like it's ready for review! Can we get it merged so that we can get Snowflake JDBC working with Java 17? [snowflakedb/snowflake-jdbc#589](https://github.com/snowflakedb/snowflake-jdbc/issues/589)
   > 
   > Any update on this? Our team is also looking to have the Snowflake JDBC working with Java 17.
   
   Same. It's been 5 mo since last update. Can someone provide a status? or timeline 🤞?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1825774211

   I found this PR too difficult to rebase (there have been several changes to Netty and Memory classes and tests in 2023) so I started a new one based on this work at #38876)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1825774908

   This work has been migrated to #38876.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #13072: ARROW-16328: [Java] Initial draft to experiment with java module system

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1118525359

   :warning: Ticket **has no components in JIRA**, make sure you assign one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jdimeo commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by GitBox <gi...@apache.org>.
jdimeo commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1301079141

   This looks like it's ready for review! Can we get it merged so that we can get Snowflake JDBC working with Java 17?
   https://github.com/snowflakedb/snowflake-jdbc/issues/589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] danepitkin commented on pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1730266260

   Arrow first needs to deprecate Java 8 support since Modules were introduced in Java 9. There's a recent discussion on this in the Arrow Mailing list[1].
   
   [1] https://lists.apache.org/thread/s07jx58yw4mkl54t3bkggnyg0sftcrr8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo closed pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System
URL: https://github.com/apache/arrow/pull/13072


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "jduo (via GitHub)" <gi...@apache.org>.
jduo commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1817260042

   Hi all,
   
   I'm investigating this now. It seems grpc recently got properly modularized in 1.57 (https://github.com/grpc/grpc-java/issues/3522) so we can rework the Flight modules.
   
   As far as compiling the module-info.java files:
   - There is a [Gradle plugin](https://github.com/Glavo/module-info-compiler) that can do a purely syntactic compilation of a module-info.java file into byte-code. It does not require rebuilding classes so I don't think we'll run into the Unsafe issues here. It will need to be rebuilt as a Maven plugin. This plugin does not handle annotations though, which does require classpath walking.
   - A multi-module build using toolchans is suggested [here](https://stackoverflow.com/questions/53560584/java9-release-8-with-internal-packages-e-g-sun-misc-unsafe) for dealing with this problem as well. This might be more reliable since it uses official tooling, though it essentially doubles the compilation time (since you need to compile all source files twice).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System [arrow]

Posted by "mmendonca2 (via GitHub)" <gi...@apache.org>.
mmendonca2 commented on PR #13072:
URL: https://github.com/apache/arrow/pull/13072#issuecomment-1814970999

   Could this be reopened? The blocker seems to have been in PR for a while: https://github.com/apache/arrow/issues/38051
   It's still a relevant issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org