You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "lhutton1 (via GitHub)" <gi...@apache.org> on 2023/07/13 09:01:37 UTC
[GitHub] [tvm] lhutton1 opened a new pull request, #15311: [topi] Add `arm_cpu` specific pooling schedules
lhutton1 opened a new pull request, #15311:
URL: https://github.com/apache/tvm/pull/15311
This commit:
* Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors.
* Enables topi testing of new `arm_cpu` schedules.
cc @neildhickey @ekalda @FranklandJack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1633847639
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1644166504
We're still seeing a circular import:
```
Traceback (most recent call last):
File "/.../lib/python3.8/site-packages/_pytest/config/__init__.py", line 774, in import_plugin
__import__(importspec)
File "/local/path/python/tvm/testing/__init__.py", line 21, in <module>
from . import auto_scheduler, autotvm
File "/local/path/python/tvm/testing/auto_scheduler.py", line 20, in <module>
from tvm import auto_scheduler, te, topi
File "/local/path/python/tvm/topi/__init__.py", line 51, in <module>
from . import nn
File "/local/path/python/tvm/topi/nn/__init__.py", line 35, in <module>
from .conv3d_transpose import *
File "/local/path/python/tvm/topi/nn/conv3d_transpose.py", line 21, in <module>
from tvm import relay
File "/local/path/python/tvm/relay/__init__.py", line 29, in <module>
from . import prelude
File "/local/path/python/tvm/relay/prelude.py", line 21, in <module>
from tvm.relay.transform import ToANormalFormExpr
File "/local/path/python/tvm/relay/transform/__init__.py", line 22, in <module>
from . import fake_quantization_to_integer, mixed_precision
File "/local/path/python/tvm/relay/transform/fake_quantization_to_integer.py", line 25, in <module>
from tvm.relay.qnn.op import canonicalizations
File "/local/path/python/tvm/relay/qnn/__init__.py", line 20, in <module>
from . import op
File "/local/path/python/tvm/relay/qnn/op/__init__.py", line 21, in <module>
from .qnn import *
File "/local/path/python/tvm/relay/qnn/op/qnn.py", line 26, in <module>
from tvm.relay.op.nn.utils import get_pad_tuple2d
File "/local/path/python/tvm/relay/op/__init__.py", line 35, in <module>
from . import strategy
File "/local/path/python/tvm/relay/op/strategy/__init__.py", line 24, in <module>
from . import arm_cpu
File "/local/path/python/tvm/relay/op/strategy/arm_cpu.py", line 29, in <module>
from ....topi.arm_cpu.mprofile import dsp
File "/local/path/python/tvm/topi/arm_cpu/__init__.py", line 33, in <module>
from . import qnn_alter_op
File "/local/path/python/tvm/topi/arm_cpu/qnn_alter_op.py", line 25, in <module>
from ..nn import qnn_conv2d_alter_layout, add_alter_layout, qnn_requantize_alter_layout
ImportError: cannot import name 'qnn_conv2d_alter_layout' from partially initialized module 'tvm.topi.nn' (most likely due to a circular import) (/local/path/python/tvm/topi/nn/__init__.py)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on code in PR #15311:
URL: https://github.com/apache/tvm/pull/15311#discussion_r1264131593
##########
python/tvm/topi/arm_cpu/pooling.py:
##########
@@ -17,9 +17,94 @@
# pylint: disable=invalid-name, unused-variable
"""Schedule for pooling operators"""
-from .mprofile.dsp.pool import pool_dsp_schedule
+import logging
+from tvm import topi, te
Review Comment:
is it possible not to self-import `tvm.topi` inside `tvm.topi`? there might be several existing cases, but it might lead to cyclic import at times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1635526463
This is the same commit as in https://github.com/apache/tvm/pull/14855 (credit to @FranklandJack). It was reverted by https://github.com/apache/tvm/pull/15286, although, after efforts to reproduce the failure mentioned in the PR, I've not been successful. In addition, the patch is rebased and passing CI. Happy to try to correct the import issue if there is a reproducer (cc @junrushao)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #15311:
URL: https://github.com/apache/tvm/pull/15311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1644413215
Thanks for reporting @kparzysz-quic, do you have a reproducer so I can take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a diff in pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on code in PR #15311:
URL: https://github.com/apache/tvm/pull/15311#discussion_r1267224684
##########
python/tvm/topi/arm_cpu/pooling.py:
##########
@@ -17,9 +17,94 @@
# pylint: disable=invalid-name, unused-variable
"""Schedule for pooling operators"""
-from .mprofile.dsp.pool import pool_dsp_schedule
+import logging
+from tvm import topi, te
Review Comment:
Thanks @junrushao, this should now be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1645620272
The same error. Can reproduce it by
```
pytest tests/python/unittest
```
PS: my python version is Py 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "lhutton1 (via GitHub)" <gi...@apache.org>.
lhutton1 commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1645718335
Thanks @Hzfengsy, I'll take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #15311: [topi] Add `arm_cpu` specific pooling schedules
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #15311:
URL: https://github.com/apache/tvm/pull/15311#issuecomment-1644420936
It came up in our automated tests, but I'll try to get you something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org