[jira] [Commented] (YETUS-265) maven javadocs aren't calcdiff'd correctly

["Kengo Seki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084581#comment-15084581 ] 

Kengo Seki commented on YETUS-265:
----------------------------------

Sorry I missed that. Almost +1, other than minor nits in maven_javadoc_calcdiffs:

{code}
  # first, strip :[line
  # this keeps file,column in an attempt to increase
  # accuracy in case of multiple, repeated errors
  # since the column number shouldn't change
  # if the line of code hasn't been touched
{code}

* :[line -> :line
* Column number isn't in javadoc's output, so the explanation should be fixed.

> maven javadocs aren't calcdiff'd correctly
> ------------------------------------------
>
>                 Key: YETUS-265
>                 URL: https://issues.apache.org/jira/browse/YETUS-265
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.2.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: YETUS-265.00.patch
>
>
> The sed introduced by YETUS-187 isn't properly stripping the line numbers, resulting in wrong results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)