You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/12/01 23:07:25 UTC
Review Request 28574: Moved repeated labels to Labels message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28574/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Timothy Chen.
Repository: mesos-git
Description
-------
We suggested to change hooks into manipulating task labels only. With
that in mind and based on BenH's suggestion originally, this patch set
wraps the repeated Labels field in a message when can be used without
referring to repeated field types.
Diffs
-----
include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba
Diff: https://reviews.apache.org/r/28574/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 28574: Moved repeated labels to Labels message
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28574/#review63785
-----------------------------------------------------------
Ship it!
Ship It!
include/mesos/mesos.proto
<https://reviews.apache.org/r/28574/#comment106090>
s/Label/Labels/g
- Timothy Chen
On Dec. 1, 2014, 10:31 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28574/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 10:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We suggested to change hooks into manipulating task labels only. With
> that in mind and based on BenH's suggestion originally, this patch set
> wraps the repeated Labels field in a message when can be used without
> referring to repeated field types.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e0b6375579ca7d3af03e4b59044810b8b7d2df86
>
> Diff: https://reviews.apache.org/r/28574/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 28574: Moved repeated labels to Labels message
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28574/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 2:31 p.m.)
Review request for mesos, Benjamin Hindman and Timothy Chen.
Changes
-------
rebased
Repository: mesos-git
Description
-------
We suggested to change hooks into manipulating task labels only. With
that in mind and based on BenH's suggestion originally, this patch set
wraps the repeated Labels field in a message when can be used without
referring to repeated field types.
Diffs (updated)
-----
include/mesos/mesos.proto e0b6375579ca7d3af03e4b59044810b8b7d2df86
Diff: https://reviews.apache.org/r/28574/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen