You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/20 12:54:06 UTC

[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #20281: feat: Visualize SqlLab.Query model data in Explore 📈

Antonio-RiveroMartnez commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r925570424


##########
superset/explore/commands/get.py:
##########
@@ -152,11 +153,6 @@ def run(self) -> Optional[Dict[str, Any]]:
         except (SupersetException, SQLAlchemyError):
             dataset_data = dummy_dataset_data
 
-        if dataset:

Review Comment:
   @hughhhh `DatasourceEditor` uses it, without it you would get the `Owners is invalid` error every time you try to edit a datasource in explore, so before putting back I'd like to ask if there was any particular reason why we removed it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org