You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Álvaro Alda (Created JIRA)" <ji...@apache.org> on 2011/11/30 08:55:40 UTC
[jira] [Created] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
BootstrapLogManager does not reuse the instantiated Handler
-----------------------------------------------------------
Key: KARAF-1064
URL: https://issues.apache.org/jira/browse/KARAF-1064
Project: Karaf
Issue Type: Bug
Components: karaf-core
Affects Versions: 2.2.4, cave-3.0.0
Reporter: Álvaro Alda
Fix For: cave-3.0.0, 2.2.5, 2.2.6
When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160650#comment-13160650 ]
Andreas Pieber commented on KARAF-1064:
---------------------------------------
@Álvaro: can you please reattach your patch checking the ASF License Agreement? (the checkbox besides the feather during the upload). Otherwise I wont be able to apply your patch.
Thanks.
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Álvaro Alda (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Álvaro Alda updated KARAF-1064:
-------------------------------
Attachment: patchfile.txt
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: cave-3.0.0, 2.2.4
> Reporter: Álvaro Alda
> Fix For: cave-3.0.0, 2.2.5, 2.2.6
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-1064) BootstrapLogManager does not reuse the
instantiated Handler
Posted by "Andreas Pieber (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber closed KARAF-1064.
---------------------------------
Resolution: Fixed
thank you very much for the grant!
Committing to https://svn.apache.org/repos/asf/karaf/trunk ...
M main/src/main/java/org/apache/karaf/main/util/BootstrapLogManager.java
Committed r1208988
Committing to https://svn.apache.org/repos/asf/karaf/branches/karaf-2.2.x ...
M main/src/main/java/org/apache/karaf/main/BootstrapLogManager.java
Committed r1208989
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt, patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Ioannis Canellos (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159996#comment-13159996 ]
Ioannis Canellos commented on KARAF-1064:
-----------------------------------------
Looks good to me.
I would make the getHandler method synchronized, just to be 100% that there isn't going to be a second handler created.
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160065#comment-13160065 ]
Andreas Pieber commented on KARAF-1064:
---------------------------------------
I've the same already in my queue (including sync); just having some problems to compile karaf trunk right now. Feel free to ahead and apply/close this issue; I'll try to fix the/my problems tonight otherwise
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-1064) BootstrapLogManager does not
reuse the instantiated Handler
Posted by "Andreas Pieber (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-1064 started by Andreas Pieber.
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Andreas Pieber (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-1064:
----------------------------------
Fix Version/s: (was: 2.2.6)
Assignee: Andreas Pieber
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Andreas Pieber (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-1064:
----------------------------------
Affects Version/s: (was: cave-3.0.0)
3.0.0
Fix Version/s: (was: cave-3.0.0)
3.0.0
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Fix For: 2.2.5, 2.2.6, 3.0.0
>
> Attachments: patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1064) BootstrapLogManager does not reuse
the instantiated Handler
Posted by "Álvaro Alda (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Álvaro Alda updated KARAF-1064:
-------------------------------
Attachment: patchfile.txt
with grant
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt, patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (KARAF-1064) BootstrapLogManager does
not reuse the instantiated Handler
Posted by "Álvaro Alda (Issue Comment Edited JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160714#comment-13160714 ]
Álvaro Alda edited comment on KARAF-1064 at 12/1/11 8:01 AM:
-------------------------------------------------------------
Attached with grants. Sorry...
was (Author: alvaro.alda):
with grant
> BootstrapLogManager does not reuse the instantiated Handler
> -----------------------------------------------------------
>
> Key: KARAF-1064
> URL: https://issues.apache.org/jira/browse/KARAF-1064
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 2.2.4, 3.0.0
> Reporter: Álvaro Alda
> Assignee: Andreas Pieber
> Fix For: 2.2.5, 3.0.0
>
> Attachments: patchfile.txt, patchfile.txt
>
>
> When running Karaf in Master/Slave mode, the method getDefaultHandler() in class org.apache.karaf.main.BootstrapLogManager is being invoked twice, one time in org.apache.karaf.main.Main and another one in the lock file class (SimpleFileLock or DefaultJDBCLock), but the object instance of the Handler class is created without closing the previous one.
> I have created a patch which completes the singleton pattern, returning the previous handler if the instance is not null. The patch has been created against the trunk, but you can apply it to branch karaf-2.2.x.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira