You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/15 22:10:39 UTC
[GitHub] [airflow] odracci opened a new pull request #9845: Fix PodGenerator to handle Kubernetes resources
odracci opened a new pull request #9845:
URL: https://github.com/apache/airflow/pull/9845
Fix the issue #9812
In Airflow 1.10.11, `namespaced['resources'] = resources` is missing.
This PR improves the definition of pod resources, `requests` and `limits` are optional.
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-661133624
This is much "better way" https://github.com/apache/airflow/pull/9889. @kaxil -I understood so far that v1-10-stable was (from time totime) rebased on top of v1-10-test (is this still the case ? Or do we want stable to be only PRs by people and cherry-picks done separately in v1-10-test?
If the rebase is in-game, I think I would like to cherry-pick the requirement change to v1-10-test and then once the tests are OK rebase v1-10-stable on top of it. Does it make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] odracci commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
odracci commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-669552380
> @odracci can you please rebase? I have the k8s tests passing
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] odracci commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
odracci commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-659699854
The build fails with:
`Could not find a version that satisfies the requirement pandas==0.25.3 (from -c https://raw.githubusercontent.com/apache/airflow/v1-10-test/requirements/requirements-python2.7.txt`
Why CI uses requirements from `v1-10-test` instead of `v1-10-stable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-661952887
@odracci can you please rebase? I have the k8s tests passing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-774218955
@odracci I'm going to close this issue but please let me know if this issue is still a problem in 1.10.14 and we can re-open/merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-661956065
> This is much "better way" #9889. @kaxil -I understood so far that v1-10-stable was (from time totime) rebased on top of v1-10-test (is this still the case ? Or do we want stable to be only PRs by people and cherry-picks done separately in v1-10-test?
>
> If the rebase is in-game, I think I would like to cherry-pick the requirement change to v1-10-test and then once the tests are OK rebase v1-10-stable on top of it. Does it make sense?
We only rebase v1-10-stable before cutting out a release. But we would rebase v1-10-test on v1-10-stable from time to time since most/all PRs targeting v1.10.* would be against v1-10-stable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-669218294
I think https://github.com/apache/airflow/pull/10140 and this one address the same problem I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-659450887
Just line too long for flake @kaxil :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-729741335
This is no longer needed correct @dimberman ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-661130733
I have changed the way of handling requirements now in "master" and I want to cherry-pick it to v1-10-test, but i think it's worth to do it for v1-10-stable. WDYT @kaxil @dimberman ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9845:
URL: https://github.com/apache/airflow/pull/9845#issuecomment-706789523
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #9845: Fix PodGenerator to handle Kubernetes resources
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #9845:
URL: https://github.com/apache/airflow/pull/9845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org