[GitHub] [spark] huaxingao commented on issue #27374: [SPARK-30659][ML][PYSPARK] LogisticRegression blockify input vectors

[GitBox <gi...@apache.org>]

huaxingao commented on issue #27374: [SPARK-30659][ML][PYSPARK] LogisticRegression blockify input vectors
URL: https://github.com/apache/spark/pull/27374#issuecomment-583039999
 
 
   I can revert my PR https://github.com/apache/spark/pull/27389. But before I revert, I want to check with you folks.  My PR only has API changes:
   1. add ```HasBlockSize``` to ALS so user can specify the blockSize for method ```blockify```
   2. make MLP extend ```HasBlockSize``` in ```sharedParams.scala``` instead of having its own param ```blockSize```
   
   It seems to me it's OK to keep these changes. Of course,  there is no ```HasBlockSize``` in ```sharedParams.scala``` any more after reverting https://github.com/apache/spark/pull/27360. I guess I can put ```HasBlockSize``` in ```sharedParams.scala``` instead of reverting my PR?
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org