You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/13 14:12:01 UTC

[GitHub] [flink] AHeise commented on a change in pull request #10976: [FLINK-13978][build system] Add experimental support for building on Azure Pipelines

AHeise commented on a change in pull request #10976: [FLINK-13978][build system] Add experimental support for building on Azure Pipelines
URL: https://github.com/apache/flink/pull/10976#discussion_r378883513
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common_s3_minio.sh
 ##########
 @@ -43,18 +56,18 @@ S3_TEST_DATA_WORDS_URI="s3://$IT_CASE_S3_BUCKET/words"
 #   S3_ENDPOINT
 ###################################
 function s3_start {
-  echo "Spawning minio for s3 tests"
+  echo "Spawning minio for s3 tests with DATA_DIR=$DATA_DIR"
   export MINIO_CONTAINER_ID=$(docker run -d \
-    -P \
-    --mount type=bind,source="$TEST_INFRA_DIR",target=/data \
 
 Review comment:
   LGTM. A few things are quite specific, but given that we will replace these tests with Java soonish, I'd not invest too much time in it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services