[GitHub] [arrow-datafusion] alamb commented on issue #6335: Add extension plan supports for substrait

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on issue #6335:
URL: https://github.com/apache/arrow-datafusion/issues/6335#issuecomment-1545959085

   Adding these functions to UserDefinedLogicalNode makes a lot of sense to me (as eventually to serialize some user defined node, the extension will have to define the mapping to/from Substrait)
   
   I think the default implementations can return "NotImplemented" which will not be a breaking change:
   
   ```rust
   
       fn to_substrait(&self) -> Result<Vec<u8>> {
          Err(DataFusionError::NotImplemented(format!("nice error message here")))
       }
   
       fn from_substrait(&self, buf: &[u8]) -> Result<Arc<dyn UserDefinedLogicalNode>> {
          Err(DataFusionError::NotImplemented(format!("nice error message here")))
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org