You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/05 23:27:28 UTC

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

stu01509 commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607390581



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -257,15 +249,16 @@ const UpstreamForm: React.FC<Props> = forwardRef(
 
     const ActiveHealthCheck = () => (
       <>
-        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })}>
+        <Form.Item label={formatMessage({ id: 'page.upstream.step.healthyCheck.active.timeout' })} tooltip="主动健康检查的套接字的超时时间">
           <Form.Item name={['checks', 'active', 'timeout']} noStyle>

Review comment:
       `主动健康检查的套接字的超时时间` maybe need to declare in locales file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org