You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2011/09/19 16:54:04 UTC
svn commit: r1172651 -
/httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java
Author: sebb
Date: Mon Sep 19 14:54:03 2011
New Revision: 1172651
URL: http://svn.apache.org/viewvc?rev=1172651&view=rev
Log:
Client connection counts were not being maintained (were always zero)
Modified:
httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java
Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java?rev=1172651&r1=1172650&r2=1172651&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java (original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestDefaultIOReactors.java Mon Sep 19 14:54:03 2011
@@ -136,13 +136,13 @@ public class TestDefaultIOReactors exten
@Override
public void connected(final NHttpClientConnection conn, final Object attachment) {
- openServerConns.incrementAndGet();
+ openClientConns.incrementAndGet();
super.connected(conn, attachment);
}
@Override
public void closed(final NHttpClientConnection conn) {
- closedServerConns.incrementAndGet();
+ closedClientConns.incrementAndGet();
super.closed(conn);
}
@@ -174,8 +174,9 @@ public class TestDefaultIOReactors exten
this.client.shutdown();
this.server.shutdown();
- Assert.assertEquals(openClientConns.get(), closedClientConns.get());
- Assert.assertEquals(openServerConns.get(), closedServerConns.get());
+ Assert.assertEquals("Client connections that should have been opened", connNo, openClientConns.get());
+ Assert.assertEquals("Client connections that should have been closed", openClientConns.get(), closedClientConns.get());
+ Assert.assertEquals("Server connections that should have been closed", openServerConns.get(), closedServerConns.get());
}
@Test