You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by jcmcote <gi...@git.apache.org> on 2016/08/22 18:00:11 UTC
[GitHub] drill pull request #573: Drill 4858
GitHub user jcmcote opened a pull request:
https://github.com/apache/drill/pull/573
Drill 4858
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcmcote/drill DRILL-4858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #573
----
commit b1c6bc1d387f22cad959bff3edb7c1ef28990b50
Author: jean-claude cote <jc...@gmail.com>
Date: 2016-05-20T02:21:39Z
working
commit 9a30d183197c54d5155b8c1e44c43ffa104d4b5c
Author: jean-claude cote <jc...@gmail.com>
Date: 2016-08-22T13:38:50Z
Merge branch 'master' of https://github.com/apache/drill
commit acd08439873f935b5eabebe32dae4af87b9e97db
Author: jean-claude cote <jc...@gmail.com>
Date: 2016-08-22T17:55:09Z
DRILL-4858 enabled the repeated_count for map/list
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #573: Drill 4858
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/573
Unit tests? If this repeated maps have never been enabled, how do we know that the code actually works for this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #573: Drill 4858
Posted by jcmcote <gi...@git.apache.org>.
Github user jcmcote commented on the issue:
https://github.com/apache/drill/pull/573
Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #573: Drill 4858
Posted by jcmcote <gi...@git.apache.org>.
Github user jcmcote commented on the issue:
https://github.com/apache/drill/pull/573
Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #573: Drill 4858
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/573
+1 for the fix. I'll add the unit test based on the examples in the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #573: Drill 4858
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/573#discussion_r82305362
--- Diff: exec/java-exec/src/main/codegen/templates/TypeHelper.java ---
@@ -68,8 +68,23 @@ public static JType getHolderType(JCodeModel model, MinorType type, DataMode mod
case UNION:
return model._ref(UnionHolder.class);
case MAP:
+ switch (mode) {
+ case REQUIRED:
--- End diff --
Perhaps combine the case statements to avoid repeated code:
case REQUIRED:
case OPTIONAL:
return model...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #573: Drill 4858
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/573
Oops. This change breaks a bunch of unit tests.
-1 until we fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---