You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2011/03/14 14:46:29 UTC
[jira] Created: (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
---------------------------------------------------------------
Key: HADOOP-7187
URL: https://issues.apache.org/jira/browse/HADOOP-7187
Project: Hadoop Common
Issue Type: Bug
Components: metrics
Environment: Linux
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7187:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
0.22.0
0.21.1
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Uma!
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.21.1, 0.22.0, 0.23.0
>
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7187:
----------------------------------------
Attachment: HADOOP-7187.1.patch
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7187:
----------------------------------------
Attachment: HADOOP-7187.patch
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010804#comment-13010804 ]
Uma Maheswara Rao G commented on HADOOP-7187:
---------------------------------------------
Hi Nicholas,
Thanks for your comments,
I fixed them and submitted the patch.
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7187:
----------------------------------------
Status: Patch Available (was: Open)
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010450#comment-13010450 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7187:
------------------------------------------------
Good catch.
- Could you add {{@Override}} to {{close()}}?
- Please use junit 4 (i.e. {{org.junit.Test}} and other classes org.junit.* instead of {{junit.framework.TestCase}})
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010952#comment-13010952 ]
Hudson commented on HADOOP-7187:
--------------------------------
Integrated in Hadoop-Common-22-branch #36 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/36/])
HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.22.0, 0.23.0
>
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7187:
-------------------------------------------
Fix Version/s: (was: 0.21.1)
Reverted it from 0.21 since {{TestGangliaContext}} cannot be compiled.
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.22.0, 0.23.0
>
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010915#comment-13010915 ]
Hudson commented on HADOOP-7187:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #535 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/535/])
HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.21.1, 0.22.0, 0.23.0
>
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7187:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010852#comment-13010852 ]
Hadoop QA commented on HADOOP-7187:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474507/HADOOP-7187.1.patch
against trunk revision 1085043.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//console
This message is automatically generated.
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7187) Socket Leak in
org.apache.hadoop.metrics.ganglia.GangliaContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011156#comment-13011156 ]
Hudson commented on HADOOP-7187:
--------------------------------
Integrated in Hadoop-Common-trunk #641 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/641/])
HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G
> Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext
> ---------------------------------------------------------------
>
> Key: HADOOP-7187
> URL: https://issues.apache.org/jira/browse/HADOOP-7187
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.22.0, 0.23.0
>
> Attachments: HADOOP-7187.1.patch, HADOOP-7187.patch
>
>
> Init method is creating DatagramSocket. But this is not closed any where.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira