You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Robert Simmons <kr...@arcor.de> on 2004/09/27 01:34:38 UTC
javahl Type Safety issue.
Greetings.
I noticed that there are a number of enumerations in the javahl Java code.
For example, look at NodeKind. I wonder if these could be converted to
typesafe enum pattern [1][2] It shouldn't be that big of a deal I would
think and would make the interface much tighter and typesafe.
References:
[1] Bloch, Josh (2001), "Effective Java Programming Language Guide", Page
104, Addison-Wesley, ISBN 0-201-31005-8
[2] Simmons, Robert (2004), "Hardcore Java", Page 168-182, O'Reilly, ISBN
0-596-00568
-- Robert Simmons Jr.
-- Senior Software Architect, Consultant
-- jambit GmbH
Re: javahl Type Safety issue.
Posted by Patrick Mayweg <ma...@qint.de>.
Hi McLain and Robert,
McClain Looney wrote:
>Unless there is some compelling failure, danger or performance problem
>being caused by this not adhering to the best possible design pattern, this
>should not be changed. There are numerous projects depending on this
>library, changing things for the sake of "tightness" may cause
>unnecessary pain.
>
since not breaking existing software build on javahl is very important
for me, I do not think I would commit such a change, unless it is an
additional feature.
Patrick
>
>
>----- Original Message -----
>From: Robert Simmons <kr...@arcor.de>
>Date: Mon, 27 Sep 2004 03:34:38 +0200
>Subject: javahl Type Safety issue.
>To: dev@subversion.tigris.org
>
>
>
>
>
>Greetings.
>
>
>
>I noticed that there are a number of enumerations in the javahl Java
>code. For example, look at NodeKind. I wonder if these could be
>converted to typesafe enum pattern [1][2] It shouldn't be that big of
>a deal I would think and would make the interface much tighter and
>typesafe.
>
>
>
>References:
>
>
>
>[1] Bloch, Josh (2001), "Effective Java Programming Language Guide",
>Page 104, Addison-Wesley, ISBN 0-201-31005-8
>
>[2] Simmons, Robert (2004), "Hardcore Java", Page 168-182, O'Reilly,
>ISBN 0-596-00568
>
>
>
>-- Robert Simmons Jr.
>
>-- Senior Software Architect, Consultant
>
>-- jambit GmbH
>
>
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: javahl Type Safety issue.
Posted by McClain Looney <ml...@gmail.com>.
Unless there is some compelling failure, danger or performance problem
being caused by this not adhering to the best possible design pattern, this
should not be changed. There are numerous projects depending on this
library, changing things for the sake of "tightness" may cause
unnecessary pain.
----- Original Message -----
From: Robert Simmons <kr...@arcor.de>
Date: Mon, 27 Sep 2004 03:34:38 +0200
Subject: javahl Type Safety issue.
To: dev@subversion.tigris.org
Greetings.
I noticed that there are a number of enumerations in the javahl Java
code. For example, look at NodeKind. I wonder if these could be
converted to typesafe enum pattern [1][2] It shouldn't be that big of
a deal I would think and would make the interface much tighter and
typesafe.
References:
[1] Bloch, Josh (2001), "Effective Java Programming Language Guide",
Page 104, Addison-Wesley, ISBN 0-201-31005-8
[2] Simmons, Robert (2004), "Hardcore Java", Page 168-182, O'Reilly,
ISBN 0-596-00568
-- Robert Simmons Jr.
-- Senior Software Architect, Consultant
-- jambit GmbH
--
McClain Looney
m@loonsoft.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org