You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/15 13:16:54 UTC

[GitHub] [incubator-nuttx] PeterBee97 commented on pull request #4550: ESP32C3 PWM Driver fix && LCD Drivers

PeterBee97 commented on pull request #4550:
URL: https://github.com/apache/incubator-nuttx/pull/4550#issuecomment-920009607


   > This PR could be broken down into at least 3 smaller PRs:
   > 
   > 1. New display drivers
   > 2. ESP32-C3 support for the new display drivers (depends on **1**)
   > 3. ESP32-C3 PWM fixes
   > 
   > Just by reading the PR title and description, I would never know that **1** is also included in this PR.
   > One **1** is, IMHO, the most relevant contribution to the project in this PR.
   > 
   > I suggest that at least open a new PR with the new display drivers, so that this new contribution does not go unnoticed by the others.
   
   Thanks for the suggestion, I will split it in separate PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org