Re: [PR] [FLINK-35936][cdc-connector][paimon] Fix paimon cdc schema evolution failure when restart job [flink-cdc]

["lvyanquan (via GitHub)" <gi...@apache.org>]

lvyanquan commented on code in PR #3502:
URL: https://github.com/apache/flink-cdc/pull/3502#discussion_r1729787373


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonMetadataApplierTest.java:
##########
@@ -416,4 +416,87 @@ public void testAddColumnWithPosition(String metastore)
         Assertions.assertEquals(
                 tableSchema, catalog.getTable(Identifier.fromString("test.table1")).rowType());
     }
+
+    @ParameterizedTest
+    @ValueSource(strings = {"filesystem", "hive"})
+    public void testOfflineAlterExistsTableSchema(String metastore)

Review Comment:
   I think this change carries risks, I tend to add a sink option to explicitly support this matter:
   When the upstream and downstream table structures are inconsistent, users can manually modify the table structure to adapt.
   If this is done in the program, in the case where the user configures the wrong `route` rule (which is not a particularly rare situation), the situation where the table structure does not correspond does not throw an exception. We will forcibly modify downstream tables to adapt, and the user will not be aware of this error.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org