You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "smiklos (via GitHub)" <gi...@apache.org> on 2023/08/02 10:07:55 UTC

[GitHub] [arrow-rs] smiklos commented on pull request #4626: allow zero sized empty fixed

smiklos commented on PR #4626:
URL: https://github.com/apache/arrow-rs/pull/4626#issuecomment-1661929922

   @tustvold 
   
   My concern with this is that  `FixedSizeList::value_offset` will always return 0 if value_length is 0. 
   This could be an issue if callers expect `FixedSizeList::value` to panic if the index is out of bound, which it won't rn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org